chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc - Issue 335753004: [fsp] Cleanup handling errors for operation requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

Issue 335753004: [fsp] Cleanup handling errors for operation requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_directory.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/read_file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

index 26ca85cb3d590ac19debdace1e1df55ef873a756..3764501dd68d58df3912fa8fb812cb6f5850a496 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

@@ -171,7 +171,6 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, Execute_NoListener) {

}

TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnSuccess) {

- using extensions::api::file_system_provider::EntryMetadata;

using extensions::api::file_system_provider_internal::

ReadDirectoryRequestedSuccess::Params;

@@ -242,10 +241,6 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnSuccess) {

}

TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnError) {

- using extensions::api::file_system_provider::EntryMetadata;

- using extensions::api::file_system_provider_internal::

- ReadDirectoryRequestedSuccess::Params;

LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);

CallbackLogger callback_logger;

@@ -260,7 +255,9 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnError) {

EXPECT_TRUE(read_directory.Execute(kRequestId));

- read_directory.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);

+ read_directory.OnError(kRequestId,

+ scoped_ptr<RequestValue>(new RequestValue()),

+ base::File::FILE_ERROR_TOO_MANY_OPENED);

ASSERT_EQ(1u, callback_logger.events().size());

CallbackLogger::Event* event = callback_logger.events()[0];