Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

Issue 335753004: [fsp] Cleanup handling errors for operation requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 224
225 ASSERT_EQ(1u, callback_logger.events().size()); 225 ASSERT_EQ(1u, callback_logger.events().size());
226 CallbackLogger::Event* event = callback_logger.events()[0]; 226 CallbackLogger::Event* event = callback_logger.events()[0];
227 EXPECT_EQ(kLength, event->chunk_length()); 227 EXPECT_EQ(kLength, event->chunk_length());
228 EXPECT_FALSE(event->has_more()); 228 EXPECT_FALSE(event->has_more());
229 EXPECT_EQ(data, std::string(io_buffer_->data(), kLength)); 229 EXPECT_EQ(data, std::string(io_buffer_->data(), kLength));
230 EXPECT_EQ(base::File::FILE_OK, event->result()); 230 EXPECT_EQ(base::File::FILE_OK, event->result());
231 } 231 }
232 232
233 TEST_F(FileSystemProviderOperationsReadFileTest, OnError) { 233 TEST_F(FileSystemProviderOperationsReadFileTest, OnError) {
234 using extensions::api::file_system_provider_internal::ReadFileRequestedError::
235 Params;
236
237 LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */); 234 LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
238 CallbackLogger callback_logger; 235 CallbackLogger callback_logger;
239 236
240 ReadFile read_file( 237 ReadFile read_file(
241 NULL, 238 NULL,
242 file_system_info_, 239 file_system_info_,
243 kFileHandle, 240 kFileHandle,
244 io_buffer_.get(), 241 io_buffer_.get(),
245 kOffset, 242 kOffset,
246 kLength, 243 kLength,
247 base::Bind(&CallbackLogger::OnReadFile, callback_logger.GetWeakPtr())); 244 base::Bind(&CallbackLogger::OnReadFile, callback_logger.GetWeakPtr()));
248 read_file.SetDispatchEventImplForTesting( 245 read_file.SetDispatchEventImplForTesting(
249 base::Bind(&LoggingDispatchEventImpl::OnDispatchEventImpl, 246 base::Bind(&LoggingDispatchEventImpl::OnDispatchEventImpl,
250 base::Unretained(&dispatcher))); 247 base::Unretained(&dispatcher)));
251 248
252 EXPECT_TRUE(read_file.Execute(kRequestId)); 249 EXPECT_TRUE(read_file.Execute(kRequestId));
253 250
254 read_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED); 251 read_file.OnError(kRequestId,
252 scoped_ptr<RequestValue>(new RequestValue()),
253 base::File::FILE_ERROR_TOO_MANY_OPENED);
255 254
256 ASSERT_EQ(1u, callback_logger.events().size()); 255 ASSERT_EQ(1u, callback_logger.events().size());
257 CallbackLogger::Event* event = callback_logger.events()[0]; 256 CallbackLogger::Event* event = callback_logger.events()[0];
258 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result()); 257 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
259 } 258 }
260 259
261 } // namespace operations 260 } // namespace operations
262 } // namespace file_system_provider 261 } // namespace file_system_provider
263 } // namespace chromeos 262 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698