Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached (Closed)

Created:
6 years, 6 months ago by Fady Samuel
Modified:
6 years, 6 months ago
Reviewers:
jam, lazyboy
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_adview
Project:
chromium
Visibility:
Public.

Description

Remove ContentBrowserClient::GuestWebContentsAttached BUG=364141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278846

Patch Set 1 #

Patch Set 2 : Added missing file #

Total comments: 8

Patch Set 3 : Addressed Istiaque's comments #

Patch Set 4 : Fix WebViewInteractiveTest #

Patch Set 5 : Fixed tests on Windows hopefully #

Patch Set 6 : Hopefully fix Windows build #

Patch Set 7 : Fixed test flake hopefully #

Patch Set 8 : Hopefully fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -246 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 2 3 4 5 9 chunks +45 lines, -21 lines 0 comments Download
M chrome/browser/apps/web_view_interactive_browsertest.cc View 1 2 3 4 5 7 chunks +67 lines, -42 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/guest_view/guest_view.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.h View 1 2 3 4 5 6 5 chunks +29 lines, -8 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.cc View 1 2 3 4 5 6 4 chunks +34 lines, -33 lines 0 comments Download
M chrome/browser/guest_view/guest_view_manager.h View 1 2 3 4 5 5 chunks +18 lines, -4 lines 0 comments Download
M chrome/browser/guest_view/guest_view_manager.cc View 3 chunks +9 lines, -1 line 0 comments Download
A chrome/browser/guest_view/guest_view_manager_factory.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_manager_unittest.cc View 1 2 3 4 5 2 chunks +26 lines, -17 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.h View 1 2 3 4 5 6 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 4 5 6 7 chunks +48 lines, -54 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 chunk +1 line, -11 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 3 4 5 6 3 chunks +6 lines, -5 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 2 3 4 5 6 1 chunk +6 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Fady Samuel
6 years, 6 months ago (2014-06-13 15:54:14 UTC) #1
lazyboy
https://chromiumcodereview.appspot.com/334923002/diff/20001/chrome/browser/apps/web_view_browsertest.cc File chrome/browser/apps/web_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/334923002/diff/20001/chrome/browser/apps/web_view_browsertest.cc#newcode6 chrome/browser/apps/web_view_browsertest.cc:6: #include "base/memory/singleton.h" Do you need this? https://chromiumcodereview.appspot.com/334923002/diff/20001/chrome/browser/apps/web_view_interactive_browsertest.cc File chrome/browser/apps/web_view_interactive_browsertest.cc ...
6 years, 6 months ago (2014-06-13 17:40:01 UTC) #2
Fady Samuel
PTAL https://codereview.chromium.org/334923002/diff/20001/chrome/browser/apps/web_view_browsertest.cc File chrome/browser/apps/web_view_browsertest.cc (right): https://codereview.chromium.org/334923002/diff/20001/chrome/browser/apps/web_view_browsertest.cc#newcode6 chrome/browser/apps/web_view_browsertest.cc:6: #include "base/memory/singleton.h" On 2014/06/13 17:40:01, lazyboy wrote: > ...
6 years, 6 months ago (2014-06-16 14:35:41 UTC) #3
lazyboy
lgtm
6 years, 6 months ago (2014-06-16 16:06:34 UTC) #4
Fady Samuel
+jam@ for content/public changes. Thanks!
6 years, 6 months ago (2014-06-16 16:08:04 UTC) #5
jam
lgtm
6 years, 6 months ago (2014-06-16 16:20:26 UTC) #6
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-06-16 16:21:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/334923002/40001
6 years, 6 months ago (2014-06-16 16:21:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 21:24:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/38094) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/34775) linux_chromium_rel ...
6 years, 6 months ago (2014-06-16 21:24:33 UTC) #10
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-06-16 21:53:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/334923002/60001
6 years, 6 months ago (2014-06-16 21:54:43 UTC) #12
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-06-17 02:57:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/334923002/80001
6 years, 6 months ago (2014-06-17 02:58:42 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 12:23:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/20987)
6 years, 6 months ago (2014-06-17 12:23:31 UTC) #16
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-06-17 14:56:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/334923002/100001
6 years, 6 months ago (2014-06-17 14:57:41 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 22:47:08 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/28353)
6 years, 6 months ago (2014-06-17 22:47:09 UTC) #20
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-06-20 15:07:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/334923002/140001
6 years, 6 months ago (2014-06-20 15:09:27 UTC) #22
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 22:42:48 UTC) #23
Message was sent while issue was closed. 
Change committed as 278846

Powered by Google App Engine
This is Rietveld 408576698