Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/guest_view/guest_view_manager.cc

Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_adview
Patch Set: Hopefully fixed tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/guest_view/guest_view_manager.h" 5 #include "chrome/browser/guest_view/guest_view_manager.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/guest_view/guest_view_base.h" 9 #include "chrome/browser/guest_view/guest_view_base.h"
10 #include "chrome/browser/guest_view/guest_view_constants.h" 10 #include "chrome/browser/guest_view/guest_view_constants.h"
11 #include "chrome/browser/guest_view/guest_view_manager_factory.h"
11 #include "chrome/browser/guest_view/web_view/web_view_guest.h" 12 #include "chrome/browser/guest_view/web_view/web_view_guest.h"
12 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
13 #include "content/public/browser/browser_context.h" 14 #include "content/public/browser/browser_context.h"
14 #include "content/public/browser/render_process_host.h" 15 #include "content/public/browser/render_process_host.h"
15 #include "content/public/browser/user_metrics.h" 16 #include "content/public/browser/user_metrics.h"
16 #include "content/public/browser/web_contents_observer.h" 17 #include "content/public/browser/web_contents_observer.h"
17 #include "content/public/common/result_codes.h" 18 #include "content/public/common/result_codes.h"
18 #include "content/public/common/url_constants.h" 19 #include "content/public/common/url_constants.h"
19 #include "extensions/browser/extension_system.h" 20 #include "extensions/browser/extension_system.h"
20 #include "net/base/escape.h" 21 #include "net/base/escape.h"
21 #include "url/gurl.h" 22 #include "url/gurl.h"
22 23
23 using content::BrowserContext; 24 using content::BrowserContext;
24 using content::SiteInstance; 25 using content::SiteInstance;
25 using content::WebContents; 26 using content::WebContents;
26 27
28 // static
29 GuestViewManagerFactory* GuestViewManager::factory_ = NULL;
30
27 GuestViewManager::GuestViewManager(content::BrowserContext* context) 31 GuestViewManager::GuestViewManager(content::BrowserContext* context)
28 : current_instance_id_(0), last_instance_id_removed_(0), context_(context) { 32 : current_instance_id_(0), last_instance_id_removed_(0), context_(context) {
29 } 33 }
30 34
31 GuestViewManager::~GuestViewManager() {} 35 GuestViewManager::~GuestViewManager() {}
32 36
33 // static. 37 // static.
34 GuestViewManager* GuestViewManager::FromBrowserContext( 38 GuestViewManager* GuestViewManager::FromBrowserContext(
35 BrowserContext* context) { 39 BrowserContext* context) {
36 GuestViewManager* guest_manager = 40 GuestViewManager* guest_manager =
37 static_cast<GuestViewManager*>(context->GetUserData( 41 static_cast<GuestViewManager*>(context->GetUserData(
38 guestview::kGuestViewManagerKeyName)); 42 guestview::kGuestViewManagerKeyName));
39 if (!guest_manager) { 43 if (!guest_manager) {
40 guest_manager = new GuestViewManager(context); 44 if (factory_) {
45 guest_manager = factory_->CreateGuestViewManager(context);
46 } else {
47 guest_manager = new GuestViewManager(context);
48 }
41 context->SetUserData(guestview::kGuestViewManagerKeyName, guest_manager); 49 context->SetUserData(guestview::kGuestViewManagerKeyName, guest_manager);
42 } 50 }
43 return guest_manager; 51 return guest_manager;
44 } 52 }
45 53
46 content::WebContents* GuestViewManager::GetGuestByInstanceIDSafely( 54 content::WebContents* GuestViewManager::GetGuestByInstanceIDSafely(
47 int guest_instance_id, 55 int guest_instance_id,
48 int embedder_render_process_id) { 56 int embedder_render_process_id) {
49 if (!CanEmbedderAccessInstanceIDMaybeKill(embedder_render_process_id, 57 if (!CanEmbedderAccessInstanceIDMaybeKill(embedder_render_process_id,
50 guest_instance_id)) { 58 guest_instance_id)) {
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 return false; 271 return false;
264 272
265 return embedder_render_process_id == 273 return embedder_render_process_id ==
266 guest->GetOpener()->embedder_web_contents()->GetRenderProcessHost()-> 274 guest->GetOpener()->embedder_web_contents()->GetRenderProcessHost()->
267 GetID(); 275 GetID();
268 } 276 }
269 277
270 return embedder_render_process_id == 278 return embedder_render_process_id ==
271 guest->embedder_web_contents()->GetRenderProcessHost()->GetID(); 279 guest->embedder_web_contents()->GetRenderProcessHost()->GetID();
272 } 280 }
OLDNEW
« no previous file with comments | « chrome/browser/guest_view/guest_view_manager.h ('k') | chrome/browser/guest_view/guest_view_manager_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698