Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_adview
Patch Set: Hopefully fixed tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/guest_view/guest_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index a500608f602883d1459990b340f517c526be759f..eb38aeadf13c2746be0ac3326593f21eab185e34 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -891,25 +891,6 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
#endif // defined(ENABLE_EXTENSIONS)
}
-void ChromeContentBrowserClient::GuestWebContentsAttached(
- WebContents* guest_web_contents,
- WebContents* embedder_web_contents,
- const base::DictionaryValue& extra_params) {
-#if defined(ENABLE_EXTENSIONS)
- GuestViewBase* guest = GuestViewBase::FromWebContents(guest_web_contents);
- if (!guest) {
- // It's ok to return here, since we could be running a browser plugin
- // outside an extension, and don't need to attach a
- // BrowserPluginGuestDelegate in that case;
- // e.g. running with flag --enable-browser-plugin-for-all-view-types.
- return;
- }
- guest->Attach(embedder_web_contents, extra_params);
-#else
- NOTREACHED();
-#endif // defined(ENABLE_EXTENSIONS)
-}
-
void ChromeContentBrowserClient::RenderProcessWillLaunch(
content::RenderProcessHost* host) {
int id = host->GetID();
« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/guest_view/guest_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698