Use AttachmentUploadImpl instead of FakeAttachmentUploader.

Use AttachmentUploadImpl instead of FakeAttachmentUploader.

ProfileSyncComponentsFactoryImpl now creates an AttachmentService with
an AttachmentUploadImpl instead of a fake.

Moved the logic for computing the sync server URL into
ProfileSyncService.

Currently, a new AUI is created for each AttachmentService.  In the
future, we will create one AUI that is shared among AttachmentService
instances.

ProfileSyncComponentsFactoryImplTest now uses TestBrowserThreadBundle
instead of the deprecated TestBrowserThread. PSCFIT now needs an IO
thread (for AUI's URLFetcher).

BUG=
TBR=finnur@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278006

[maniscalco, 2014-06-16 18:51:08]

Tim, would you please review this change?

[maniscalco, 2014-06-16 20:58:25]

On 2014/06/16 18:51:08, maniscalco wrote:
> Tim, would you please review this change?

Actually, you should hold off on reviewing this change.  I need to fix
somethings first.  I'll resend when ready for review.

[maniscalco, 2014-06-17 21:40:57]

On 2014/06/16 20:58:25, maniscalco wrote:
> On 2014/06/16 18:51:08, maniscalco wrote:
> > Tim, would you please review this change?
> 
> Actually, you should hold off on reviewing this change.  I need to fix
> somethings first.  I'll resend when ready for review.

Tim, should be all set now.  Please review.

[tim (not reviewing), 2014-06-18 02:59:48]

LGTM with nit

https://codereview.chromium.org/334713008/diff/200001/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/334713008/diff/200001/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_components_factory_impl.cc:632: std::string
url_prefix = sync_service_url_.spec() + "/attachments/";
Can "/attachments" be a const somewhere?  And better, have a function that takes
the sync_service_url and returns the attachment url?

[maniscalco, 2014-06-18 03:56:43]

Thanks for reviewing!

https://codereview.chromium.org/334713008/diff/200001/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/334713008/diff/200001/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_components_factory_impl.cc:632: std::string
url_prefix = sync_service_url_.spec() + "/attachments/";
On 2014/06/18 02:59:47, timsteele wrote:
> Can "/attachments" be a const somewhere?  And better, have a function that
takes
> the sync_service_url and returns the attachment url?  

Done.

[maniscalco, 2014-06-18 04:00:32]

Adding finnur as TBR.

finnur, would you please review
c/b/e/api/preferences_private/preferences_private_apitest.cc

[maniscalco, 2014-06-18 04:00:44]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-06-18 04:02:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/334713008/210001

[commit-bot: I haz the power, 2014-06-18 10:03:11]

Change committed as 278006

[Finnur, 2014-06-18 11:59:10]

preferences_private_apitest.cc rubberstamp LGRM

[Finnur, 2014-06-18 11:59:18]

On 2014/06/18 11:59:10, Finnur wrote:
> preferences_private_apitest.cc rubberstamp LGRM

LGTM even.