Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5754)

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.h

Issue 334713008: Use AttachmentUploadImpl instead of FakeAttachmentUploader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Apply CR feedback from tim. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_components_factory_impl.h
diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.h b/chrome/browser/sync/profile_sync_components_factory_impl.h
index 390ac91811ed7288bc72641719ff228baf888757..b3231e97f64c9094298f5ae0af323576dd340918 100644
--- a/chrome/browser/sync/profile_sync_components_factory_impl.h
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.h
@@ -12,6 +12,7 @@
#include "base/memory/weak_ptr.h"
#include "chrome/browser/sync/profile_sync_components_factory.h"
#include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
+#include "google_apis/gaia/oauth2_token_service.h"
class Profile;
@@ -25,8 +26,26 @@ class ExtensionSystem;
class ProfileSyncComponentsFactoryImpl : public ProfileSyncComponentsFactory {
public:
- ProfileSyncComponentsFactoryImpl(Profile* profile,
- base::CommandLine* command_line);
+ // Constructs a ProfileSyncComponentsFactoryImpl.
+ //
+ // |sync_service_url| is the base URL of the sync server.
+ //
+ // |account_id| is the sync user's account id.
+ //
+ // |scope_set| is the set of scopes to use for sync.
+ //
+ // |token_service| must outlive the ProfileSyncComponentsFactoryImpl.
+ //
+ // |url_request_context_getter| must outlive the
+ // ProfileSyncComponentsFactoryImpl.
+ ProfileSyncComponentsFactoryImpl(
+ Profile* profile,
+ base::CommandLine* command_line,
+ const GURL& sync_service_url,
+ const std::string& account_id,
+ const OAuth2TokenService::ScopeSet& scope_set,
+ OAuth2TokenService* token_service,
+ net::URLRequestContextGetter* url_request_context_getter);
virtual ~ProfileSyncComponentsFactoryImpl();
virtual void RegisterDataTypes(ProfileSyncService* pss) OVERRIDE;
@@ -91,6 +110,12 @@ class ProfileSyncComponentsFactoryImpl : public ProfileSyncComponentsFactory {
extensions::ExtensionSystem* extension_system_;
scoped_refptr<autofill::AutofillWebDataService> web_data_service_;
+ const GURL sync_service_url_;
+ const std::string account_id_;
+ const OAuth2TokenService::ScopeSet scope_set_;
+ OAuth2TokenService* const token_service_;
+ net::URLRequestContextGetter* const url_request_context_getter_;
+
base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl);

Powered by Google App Engine
This is Rietveld 408576698