Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: chrome/browser/sync/profile_sync_service_unittest.cc

Issue 334713008: Use AttachmentUploadImpl instead of FakeAttachmentUploader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Apply CR feedback from tim. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_unittest.cc b/chrome/browser/sync/profile_sync_service_unittest.cc
index ddc9a9e44ff604c99e72e8bd3c5438afeb72468c..0e2a86efb718a489269854edb82ccdc42e53cf76 100644
--- a/chrome/browser/sync/profile_sync_service_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_unittest.cc
@@ -196,7 +196,7 @@ class ProfileSyncServiceTest : public ::testing::Test {
service_.reset(new ProfileSyncService(
components_factory_,
profile_,
- new ManagedUserSigninManagerWrapper(profile_, signin),
+ make_scoped_ptr(new ManagedUserSigninManagerWrapper(profile_, signin)),
oauth2_token_service,
behavior));
service_->SetClearingBrowseringDataForTesting(
@@ -585,5 +585,21 @@ TEST_F(ProfileSyncServiceTest, RollbackThenBackup) {
}
#endif
+TEST_F(ProfileSyncServiceTest, GetSyncServiceURL) {
+ CommandLine command_line(*CommandLine::ForCurrentProcess());
+
+ // See that it defaults to a "dev" URL.
+ //
+ // Yes, we're hardcoding the URL here so this test will have to be updated
+ // when/if the URL ever changes.
+ EXPECT_EQ("https://clients4.google.com/chrome-sync/dev",
+ ProfileSyncService::GetSyncServiceURL(command_line).spec());
+
+ // See that we can override the URL with a flag.
+ command_line.AppendSwitchASCII("--sync-url", "https://foo/bar");
+ EXPECT_EQ("https://foo/bar",
+ ProfileSyncService::GetSyncServiceURL(command_line).spec());
+}
+
} // namespace
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/profile_sync_service_startup_unittest.cc ('k') | chrome/browser/sync/test_profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698