Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 333803003: Turn conditionals back on in aggregate bindings (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, maheshkk, pdr., kouhei (in TOK)
Project:
blink
Visibility:
Public.

Description

Turn conditionals back on in aggregate bindings Aggregate bindings are supposed to wrap the include of interfaces that have [Conditional] on their definition with ifdef, so these are not compiled if these are turned off. However, this was broken so it didn't work, and we couldn't turn it on, due to linking failure in SVG. (I noticed this during a cleanup.) This now can be turned back on, perhaps thanks to Kouhei's fix-up of SVG bindings (or something Mahesh has been doing?). Turning it on thus speeds up and simplifies compilation somewhat. (The only [Conditional] compilation flags on interfaces are SVG_FONTS and WEB_AUDIO.) I looked into this because of Mahesh's other Conditional fixes in: Add support in generate scripts to handle Conditional https://codereview.chromium.org/330093002/ R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/bindings/scripts/aggregate_generated_bindings.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Nils Barth (inactive)
Quick cleanup, removes a FIXME.
6 years, 6 months ago (2014-06-13 02:12:38 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-13 02:23:46 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-13 02:24:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/333803003/1
6 years, 6 months ago (2014-06-13 02:25:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 03:15:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 04:12:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11857)
6 years, 6 months ago (2014-06-13 04:12:22 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-13 04:45:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/333803003/1
6 years, 6 months ago (2014-06-13 04:46:25 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 05:35:33 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 06:29:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11868)
6 years, 6 months ago (2014-06-13 06:29:16 UTC) #12
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-13 06:37:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/333803003/1
6 years, 6 months ago (2014-06-13 06:38:38 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 08:23:05 UTC) #15
Message was sent while issue was closed.
Change committed as 176092

Powered by Google App Engine
This is Rietveld 408576698