Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: Source/bindings/scripts/aggregate_generated_bindings.py

Issue 333803003: Turn conditionals back on in aggregate bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/aggregate_generated_bindings.py
diff --git a/Source/bindings/scripts/aggregate_generated_bindings.py b/Source/bindings/scripts/aggregate_generated_bindings.py
index 3365027d4ba0703b10ba1ed62e13344d0504acd0..c6d3e3a5ed3b8ef806feb81bc9fb584d42589712 100755
--- a/Source/bindings/scripts/aggregate_generated_bindings.py
+++ b/Source/bindings/scripts/aggregate_generated_bindings.py
@@ -156,9 +156,7 @@ def generate_content(component_dir, files_meta_data_this_partition):
prev_conditional = None
files_meta_data_this_partition.sort(key=lambda e: e['conditional'])
for meta_data in files_meta_data_this_partition:
- # FIXME: linking fails (in SVG) if conditionals occur
- # conditional = meta_data['conditional']
- conditional = None
+ conditional = meta_data['conditional']
if prev_conditional != conditional:
if prev_conditional:
output.append('#endif\n')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698