LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html - Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Small fix in add/removeChild to avoid dirtying the grid in stack Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

diff --git a/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html b/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

index 7a81a10d5f8449fd3821a9c4b782ee0c369b90cc..9eee21cacdf4f2f56059c59326aa8cda04f76425 100644

--- a/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

+++ b/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

@@ -10,6 +10,7 @@ function testLayout(gridDefinitions, itemsDefinitions)

var gridContainer = document.getElementById("gridContainer");

var gridElement = document.createElement("div");

gridElement.className = "grid";

+ gridElement.style.gridAutoFlow = "stack";

for (var key in gridDefinitions) {

if (key == "rows")