Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

Issue 333563003: [CSS Grid Layout] Update grid-auto-flow to the new syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Small fix in add/removeChild to avoid dirtying the grid in stack Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <link href="resources/grid.css" rel="stylesheet"> 4 <link href="resources/grid.css" rel="stylesheet">
5 <script src="../../resources/check-layout.js"></script> 5 <script src="../../resources/check-layout.js"></script>
6 <script type="text/javascript"> 6 <script type="text/javascript">
7 7
8 function testLayout(gridDefinitions, itemsDefinitions) 8 function testLayout(gridDefinitions, itemsDefinitions)
9 { 9 {
10 var gridContainer = document.getElementById("gridContainer"); 10 var gridContainer = document.getElementById("gridContainer");
11 var gridElement = document.createElement("div"); 11 var gridElement = document.createElement("div");
12 gridElement.className = "grid"; 12 gridElement.className = "grid";
13 gridElement.style.gridAutoFlow = "stack";
13 14
14 for (var key in gridDefinitions) { 15 for (var key in gridDefinitions) {
15 if (key == "rows") 16 if (key == "rows")
16 gridElement.style.gridTemplateRows = gridDefinitions[key]; 17 gridElement.style.gridTemplateRows = gridDefinitions[key];
17 else if (key == "columns") 18 else if (key == "columns")
18 gridElement.style.gridTemplateColumns = gridDefinitions[key]; 19 gridElement.style.gridTemplateColumns = gridDefinitions[key];
19 else 20 else
20 gridElement.style.gridTemplateAreas = gridDefinitions[key]; 21 gridElement.style.gridTemplateAreas = gridDefinitions[key];
21 } 22 }
22 23
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 </head> 147 </head>
147 <body> 148 <body>
148 <div>This test checks we properly recompute the resolution of named grid lines a nd named grid areas when we change the grid positioning properties.</div> 149 <div>This test checks we properly recompute the resolution of named grid lines a nd named grid areas when we change the grid positioning properties.</div>
149 150
150 <div id="gridContainer" style="position: relative"></div> 151 <div id="gridContainer" style="position: relative"></div>
151 152
152 <div id="test-output"></div> 153 <div id="test-output"></div>
153 154
154 </body> 155 </body>
155 </html> 156 </html>
OLDNEW
« LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698