[CSS Grid Layout] Update grid-auto-flow to the new syntax

Source/core/rendering/style/RenderStyleConstants.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 465 matching lines @@
 enum ImageResolutionSnap { ImageResolutionNoSnap = 0, ImageResolutionSnapPixels };
 
 enum Order { LogicalOrder = 0, VisualOrder };
 
 enum WrapFlow { WrapFlowAuto, WrapFlowBoth, WrapFlowStart, WrapFlowEnd, WrapFlowMaximum, WrapFlowClear };
 
 enum WrapThrough { WrapThroughWrap, WrapThroughNone };
 
 enum RubyPosition { RubyPositionBefore, RubyPositionAfter };
 
-enum GridAutoFlow { AutoFlowNone, AutoFlowColumn, AutoFlowRow };
+enum GridAutoFlow { AutoFlowRow, AutoFlowColumn, AutoFlowRowDense, AutoFlowColumnDense, AutoFlowStackRow, AutoFlowStackColumn };

[Julien - ping for review, 2014/06/27 17:44:53]

I wonder if we couldn't choose the value to make for easier comparisons.

You know that you have a base value which is either 'flow', 'dense' or 'stack'
suffixed by 'row' or 'column' so we could do:

enum InternalGridAutoFlowAlgorithm {
   InternalGridAutoFlowFlow = 0x1,
    InternalGridAutoFlowDense = 0x2,
    InternalGridAutoFlowStack = 0x4
};


enum InternalGridAutoFlowDirection {
    InternalGridAutoFlowColumn = 0x10,
    InternalGridAutoFlowRow = 0x20
};

enum GridAutoFlow {
    AutoFlowRow = InternalGridAutoFlowFlow | InternalGridAutoFlowRow,
    AutoFlowColumn = InternalGridAutoFlowFlow | InternalGridAutoFlowColumn,
    AutoFlowRowDense = InternalGridAutoFlowDense | InternalGridAutoFlowRow,
    [...]
};

(It's a bit too verbose for my taste but you get the idea)

With these you can easily know if something is 'dense' or flows along the 'row'
by some simple bitwise arithmetic. We can wrap these into helper function so
that we don't expose these details to RenderGrid.

[Manuel Rego, 2014/06/27 22:43:51]

Thanks for the suggestion. I've changed it and I've added some helper functions
in RenderStyle.

Now the code in RenderGrid that needs to know if you're in row or column
direction, or if the algorithm is stack or not is much simpler.

 
 enum DraggableRegionMode { DraggableRegionNone, DraggableRegionDrag, DraggableRegionNoDrag };
 
 static const size_t TouchActionBits = 4;
 enum TouchAction {
     TouchActionAuto = 0x0,
     TouchActionNone = 0x1,
     TouchActionPanX = 0x2,
     TouchActionPanY = 0x4,
     TouchActionPinchZoom = 0x8,
@@ skipping 32 matching lines @@
 static const float maximumAllowedFontSize = 1000000.0f;
 
 enum TextIndentLine { TextIndentFirstLine, TextIndentEachLine };
 enum TextIndentType { TextIndentNormal, TextIndentHanging };
 
 enum CSSBoxType { BoxMissing = 0, MarginBox, BorderBox, PaddingBox, ContentBox };
 
 } // namespace WebCore
 
 #endif // RenderStyleConstants_h