Fixes TooltipControllerTest to create a toplevel window on Linux

Fixes TooltipControllerTest to create a toplevel tooltip window on Linux.

Also removes obsolete test cases which tested the behavior  before tooltips were toplevel windows on Linux

BUG=None
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278221

[pkotwicz, 2014-06-16 15:55:48]

Sadrul, PTAL

[sadrul, 2014-06-17 17:14:07]

+sky@ for clarification on views dep from corewm/

https://codereview.chromium.org/333333003/diff/20001/ui/views/corewm/DEPS
File ui/views/corewm/DEPS (right):

https://codereview.chromium.org/333333003/diff/20001/ui/views/corewm/DEPS#new...
ui/views/corewm/DEPS:32: "+ui/views/test/test_views_delegate.h",
I believe we want to reduce the dependency on views code from corewm/. This is
adding more.

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
File ui/views/test/desktop_test_views_delegate_aura.cc (left):

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
ui/views/test/desktop_test_views_delegate_aura.cc:30: } else if (!params->parent
&& !params->context) {
Why remove this?

[pkotwicz, 2014-06-17 18:11:29]

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
File ui/views/test/desktop_test_views_delegate_aura.cc (left):

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
ui/views/test/desktop_test_views_delegate_aura.cc:30: } else if (!params->parent
&& !params->context) {
Removing this better matches the behavior of OnBeforeWidgetInit()
ChromeViewsDelegate on Linux.
On Windows, when Aero is enabled, ChromeViewsDelegate returns
DesktopNativeWidgetAura even more often.

[sky, 2014-06-17 19:13:20]

https://codereview.chromium.org/333333003/diff/20001/ui/views/corewm/DEPS
File ui/views/corewm/DEPS (right):

https://codereview.chromium.org/333333003/diff/20001/ui/views/corewm/DEPS#new...
ui/views/corewm/DEPS:32: "+ui/views/test/test_views_delegate.h",
On 2014/06/17 17:14:07, sadrul wrote:
> I believe we want to reduce the dependency on views code from corewm/. This is
> adding more.

I think we gave up on the tooltip classes.

[pkotwicz, 2014-06-18 18:40:27]

Sadrul, Ping?

[sadrul, 2014-06-18 19:18:06]

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
File ui/views/test/desktop_test_views_delegate_aura.cc (left):

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
ui/views/test/desktop_test_views_delegate_aura.cc:30: } else if (!params->parent
&& !params->context) {
On 2014/06/17 18:11:29, pkotwicz wrote:
> Removing this better matches the behavior of OnBeforeWidgetInit()
> ChromeViewsDelegate on Linux.
> On Windows, when Aero is enabled, ChromeViewsDelegate returns
> DesktopNativeWidgetAura even more often.

Is this necessary for the rest of the tooltip-related changes?

[pkotwicz, 2014-06-18 19:26:49]

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
File ui/views/test/desktop_test_views_delegate_aura.cc (left):

https://codereview.chromium.org/333333003/diff/20001/ui/views/test/desktop_te...
ui/views/test/desktop_test_views_delegate_aura.cc:30: } else if (!params->parent
&& !params->context) {
Yes, it is necessary in order to get the tooltip to be a toplevel widget in
tests. (the tooltip is a toplevel window in production).

CreateTooltipWidget() in tooltip_aura.cc specifies params.context

[sadrul, 2014-06-18 19:31:12]

LGTM

[pkotwicz, 2014-06-18 19:45:16]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-06-18 19:46:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/333333003/20001

[commit-bot: I haz the power, 2014-06-19 01:19:19]

Change committed as 278221