Fixes TooltipControllerTest to create a toplevel window on Linux

ui/views/test/desktop_test_views_delegate_aura.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/test/desktop_test_views_delegate.h"
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #if !defined(OS_CHROMEOS)
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 #endif
 
 namespace views {
 
 DesktopTestViewsDelegate::DesktopTestViewsDelegate() {}
 
 DesktopTestViewsDelegate::~DesktopTestViewsDelegate() {}
 
 void DesktopTestViewsDelegate::OnBeforeWidgetInit(
     Widget::InitParams* params,
     internal::NativeWidgetDelegate* delegate) {
 #if !defined(OS_CHROMEOS)
   // If we already have a native_widget, we don't have to try to come
   // up with one.
   if (params->native_widget)
     return;
 
-  if (params->parent && params->type != views::Widget::InitParams::TYPE_MENU) {
+  if (params->parent &&
+      params->type != views::Widget::InitParams::TYPE_MENU &&
+      params->type != views::Widget::InitParams::TYPE_TOOLTIP) {
     params->native_widget = new views::NativeWidgetAura(delegate);
-  } else if (!params->parent && !params->context) {

[sadrul, 2014/06/17 17:14:07]

Why remove this?

[pkotwicz, 2014/06/17 18:11:29]

Removing this better matches the behavior of OnBeforeWidgetInit()
ChromeViewsDelegate on Linux.
On Windows, when Aero is enabled, ChromeViewsDelegate returns
DesktopNativeWidgetAura even more often.

[sadrul, 2014/06/18 19:18:05]

Is this necessary for the rest of the tooltip-related changes?

[pkotwicz, 2014/06/18 19:26:49]

Yes, it is necessary in order to get the tooltip to be a toplevel widget in
tests. (the tooltip is a toplevel window in production).

CreateTooltipWidget() in tooltip_aura.cc specifies params.context

+  } else {
     params->native_widget = new views::DesktopNativeWidgetAura(delegate);
   }
 #endif
 }
 
 }  // namespace views