Chromium Code Reviews Chromium Code Reviews
Issue 333333003:
Fixes TooltipControllerTest to create a toplevel window on Linux (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 # This code should not depend on Views. | 1 # This code should not depend on Views. |
| 2 | 2 |
| 3 include_rules = [ | 3 include_rules = [ |
| 4 "-ui/views", | 4 "-ui/views", |
| 5 "+ui/views/corewm", | 5 "+ui/views/corewm", |
| 6 "+ui/views/views_export.h", | 6 "+ui/views/views_export.h", |
| 7 ] | 7 ] |
| 8 | 8 |
| 9 # TODO: temporary, don't add more. | 9 # TODO: temporary, don't add more. |
| 10 specific_include_rules = { | 10 specific_include_rules = { |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 "desktop_capture_controller_unittest.cc": [ | 21 "desktop_capture_controller_unittest.cc": [ |
| 22 "+ui/views/test/views_test_base.h", | 22 "+ui/views/test/views_test_base.h", |
| 23 "+ui/views/view.h", | 23 "+ui/views/view.h", |
| 24 "+ui/views/widget/desktop_aura/desktop_native_widget_aura.h", | 24 "+ui/views/widget/desktop_aura/desktop_native_widget_aura.h", |
| 25 "+ui/views/widget/desktop_aura/desktop_screen_position_client.h", | 25 "+ui/views/widget/desktop_aura/desktop_screen_position_client.h", |
| 26 "+ui/views/widget/root_view.h", | 26 "+ui/views/widget/root_view.h", |
| 27 "+ui/views/widget/widget.h", | 27 "+ui/views/widget/widget.h", |
| 28 ], | 28 ], |
| 29 | 29 |
| 30 "tooltip_controller_unittest.cc": [ | 30 "tooltip_controller_unittest.cc": [ |
| 31 "+ui/views/test/desktop_test_views_delegate.h", | |
| 32 "+ui/views/test/test_views_delegate.h", | |
|
sadrul
2014/06/17 17:14:07
I believe we want to reduce the dependency on view
sky
2014/06/17 19:13:20
I think we gave up on the tooltip classes.
| |
| 31 "+ui/views/view.h", | 33 "+ui/views/view.h", |
| 32 "+ui/views/widget/desktop_aura/desktop_native_widget_aura.h", | 34 "+ui/views/widget/desktop_aura/desktop_native_widget_aura.h", |
| 33 "+ui/views/widget/desktop_aura/desktop_screen.h", | 35 "+ui/views/widget/desktop_aura/desktop_screen.h", |
| 34 "+ui/views/widget/tooltip_manager.h", | 36 "+ui/views/widget/tooltip_manager.h", |
| 35 "+ui/views/widget/widget.h", | 37 "+ui/views/widget/widget.h", |
| 36 ], | 38 ], |
| 37 | 39 |
| 38 "tooltip_aura.h": [ | 40 "tooltip_aura.h": [ |
| 39 "+ui/views/controls/label.h", | 41 "+ui/views/controls/label.h", |
| 40 "+ui/views/widget/widget_observer.h", | 42 "+ui/views/widget/widget_observer.h", |
| 41 ], | 43 ], |
| 42 | 44 |
| 43 "tooltip_controller_test_helper.h": [ | 45 "tooltip_controller_test_helper.h": [ |
| 44 "+ui/views/view.h", | 46 "+ui/views/view.h", |
| 45 ], | 47 ], |
| 46 | 48 |
| 47 "capture_controller_unittest.cc": [ | 49 "capture_controller_unittest.cc": [ |
| 48 "+ui/views/test/views_test_base.h", | 50 "+ui/views/test/views_test_base.h", |
| 49 "+ui/views/view.h", | 51 "+ui/views/view.h", |
| 50 "+ui/views/widget/desktop_aura/desktop_native_widget_aura.h", | 52 "+ui/views/widget/desktop_aura/desktop_native_widget_aura.h", |
| 51 "+ui/views/widget/desktop_aura/desktop_screen_position_client.h", | 53 "+ui/views/widget/desktop_aura/desktop_screen_position_client.h", |
| 52 "+ui/views/widget/root_view.h", | 54 "+ui/views/widget/root_view.h", |
| 53 "+ui/views/widget/widget.h", | 55 "+ui/views/widget/widget.h", |
| 54 ], | 56 ], |
| 55 } | 57 } |
| OLD | NEW |
