|
Removing using declarations that import names in the C++ Standard library.
The original CL https://codereview.chromium.org/329183002/ got reverted in
https://codereview.chromium.org/330933002/ as it was causing failures on the
Chromium Linux Tsan v2 bot.
The problem was that std::abs(int) is found in <cstdlib> but we apparently only
include <cmath> everywhere. So the compiler only knows about std::abs(float) and
variants.
There were two ways of fixing this:
1. include <cstdlib> whereever std::abs(int) is used.
2. use abs() as it was done earlier.
Because we already include <cmath> everywhere, and Since C++11, additional
overloads are provided in the header <cmath> for the integral types as well, so
its better to directly just use abs() rather than including an extra header file
This CL uses the second way.
BUG=None
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176179
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+79 lines, -133 lines) |
Patch |
|
M |
Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
Source/bindings/v8/custom/V8GeolocationCustom.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/animation/AnimationTranslationUtil.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/ContainerNode.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Document.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/Node.cpp
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Range.cpp
|
View
|
|
4 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Text.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/ViewportDescription.cpp
|
View
|
|
4 chunks |
+8 lines, -10 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/CompositeEditCommand.cpp
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/Editor.cpp
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/TextIterator.cpp
|
View
|
|
9 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/htmlediting.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/markup.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/fileapi/FileReaderLoader.cpp
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/frame/DOMTimer.cpp
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/frame/ImageBitmap.cpp
|
View
|
|
7 chunks |
+11 lines, -13 lines |
0 comments
|
Download
|
|
M |
Source/core/frame/LocalFrame.cpp
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/inspector/ContentSearchUtils.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/inspector/DOMEditor.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/inspector/DOMPatchSupport.cpp
|
View
|
|
5 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
|
M |
Source/core/inspector/InjectedScriptHost.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/page/ScopedPageLoadDeferrer.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/page/TouchDisambiguation.cpp
|
View
|
|
4 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/animation/SMILTimeContainer.cpp
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/animation/SVGSMILElement.cpp
|
View
|
|
8 chunks |
+9 lines, -11 lines |
0 comments
|
Download
|
|
M |
Source/core/xml/XMLTreeViewer.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/xml/parser/XMLDocumentParser.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/web/WebDevToolsAgentImpl.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/web/WebPagePopupImpl.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/web/WebPluginScrollbarImpl.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/web/WebViewImpl.cpp
|
View
|
|
7 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
|
M |
Source/web/tests/ScrollAnimatorNoneTest.cpp
|
View
|
|
3 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|