Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 332513002: Add unittest for gtest_test_results. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
dtu, nduca, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add unittest for gtest_test_results. BUG=383100 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276573

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Tony's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -44 lines) Patch
A tools/telemetry/telemetry/results/base_test_results_unittest.py View 1 1 chunk +63 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py View 2 chunks +3 lines, -35 lines 0 comments Download
A tools/telemetry/telemetry/results/gtest_test_results_unittest.py View 1 1 chunk +130 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 3 chunks +2 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/unittest/simple_mock.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-11 18:50:39 UTC) #1
tonyg
lgtm Incredible, thank you :) https://codereview.chromium.org/332513002/diff/1/tools/telemetry/telemetry/results/base_test_results_unittest.py File tools/telemetry/telemetry/results/base_test_results_unittest.py (right): https://codereview.chromium.org/332513002/diff/1/tools/telemetry/telemetry/results/base_test_results_unittest.py#newcode18 tools/telemetry/telemetry/results/base_test_results_unittest.py:18: def CreateException(self): I know ...
6 years, 6 months ago (2014-06-11 23:08:51 UTC) #2
nednguyen
https://codereview.chromium.org/332513002/diff/1/tools/telemetry/telemetry/results/base_test_results_unittest.py File tools/telemetry/telemetry/results/base_test_results_unittest.py (right): https://codereview.chromium.org/332513002/diff/1/tools/telemetry/telemetry/results/base_test_results_unittest.py#newcode18 tools/telemetry/telemetry/results/base_test_results_unittest.py:18: def CreateException(self): On 2014/06/11 23:08:51, tonyg wrote: > I ...
6 years, 6 months ago (2014-06-11 23:30:36 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-11 23:30:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/332513002/20001
6 years, 6 months ago (2014-06-11 23:32:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 01:01:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 01:07:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160501) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149908) ios_rel_device_ninja ...
6 years, 6 months ago (2014-06-12 01:07:17 UTC) #8
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-12 03:34:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/332513002/20001
6 years, 6 months ago (2014-06-12 03:36:45 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 07:57:54 UTC) #11
Message was sent while issue was closed.
Change committed as 276573

Powered by Google App Engine
This is Rietveld 408576698