Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

Issue 332513002: Add unittest for gtest_test_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Tony's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
index 8b41a938fb03bf6b23a6692d8422b78fd73953e9..dae470774027f27e0c33e78cf5f23ddca234767e 100644
--- a/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
@@ -2,12 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import os
-import unittest
from telemetry import perf_tests_helper
from telemetry.page import page_set
from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
+from telemetry.results import base_test_results_unittest
from telemetry.results import buildbot_page_measurement_results
def _MakePageSet():
@@ -28,40 +28,8 @@ class SummarySavingPageMeasurementResults(
res = perf_tests_helper.PrintPerfResult(*args, print_to_stdout=False)
self.results.append(res)
-class BuildbotPageMeasurementResultsTest(unittest.TestCase):
- def assertEquals(self, ex, res):
- # This helps diagnose result mismatches.
- if ex != res and isinstance(ex, list):
- def CleanList(l):
- res = []
- for x in l:
- x = x.split('\n')
- res.extend(x)
- return res
- ex = CleanList(ex)
- res = CleanList(res)
- max_len = max(len(ex), len(res))
- max_width = max([len(x) for x in ex + res])
- max_width = max(10, max_width)
- print "Lists differ!"
- print '%*s | %*s' % (max_width, 'expected', max_width, 'result')
- for i in range(max_len):
- if i < len(ex):
- e = ex[i]
- else:
- e = ''
- if i < len(res):
- r = res[i]
- else:
- r = ''
- if e != r:
- sep = '*'
- else:
- sep = '|'
- print '%*s %s %*s' % (max_width, e, sep, max_width, r)
- print ""
- super(BuildbotPageMeasurementResultsTest, self).assertEquals(ex, res)
-
+class BuildbotPageMeasurementResultsTest(
+ base_test_results_unittest.BaseTestResultsUnittest):
def test_basic_summary(self):
test_page_set = _MakePageSet()

Powered by Google App Engine
This is Rietveld 408576698