Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 332513002: Add unittest for gtest_test_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Tony's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_test_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py
index 7ef5f9e2182aeaea4bd1f0ebac7f9d4e8ca4f770..2aef9ed8a7921ef57db24e6d831ef5c318753303 100644
--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py
+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py
@@ -2,8 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import os
-import sys
-import unittest
+from telemetry.results import base_test_results_unittest
from telemetry.page import page_set
from telemetry.results import page_test_results
@@ -16,7 +15,7 @@ class NonPrintingPageTestResults(
def _PrintPerfResult(self, *args):
pass
-class PageTestResultsTest(unittest.TestCase):
+class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
def setUp(self):
self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
@@ -27,12 +26,6 @@ class PageTestResultsTest(unittest.TestCase):
def pages(self):
return self.page_set.pages
- def CreateException(self):
- try:
- raise Exception('Intentional exception')
- except Exception:
- return sys.exc_info()
-
def test_failures(self):
results = NonPrintingPageTestResults()
results.AddFailure(self.pages[0], self.CreateException())
« no previous file with comments | « tools/telemetry/telemetry/results/gtest_test_results_unittest.py ('k') | tools/telemetry/telemetry/unittest/simple_mock.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698