Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332303002: gpu: Add base class for gpu service tests (Closed)

Created:
6 years, 6 months ago by no sievers
Modified:
6 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

gpu: Add base class for gpu service tests This allows for properly setting up and tearing down GL bindings. Before this patch bindings were intialized in unittest_main.cc but also reinitialized with a different GL version and extension in some GLES2CmdDecoderTests which leaves room for problems depending on which order tests happen to run in. More importantly, this will allow me to initialize GL bindings with a certain GL version and extension bindings for some tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278059 R=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278136

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase, comment #

Patch Set 4 : update gpu/build.GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -195 lines) Patch
M gpu/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/unittest_main.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 5 chunks +3 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 6 chunks +4 lines, -22 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
A gpu/command_buffer/service/gpu_service_test.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gpu_service_test.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 5 chunks +21 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache_unittest.cc View 5 chunks +3 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 12 chunks +6 lines, -33 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 12 chunks +10 lines, -23 lines 0 comments Download
M gpu/command_buffer/service/vertex_array_manager_unittest.cc View 1 2 3 chunks +7 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
no sievers
ptal
6 years, 6 months ago (2014-06-16 22:23:24 UTC) #1
danakj
LGTM thanks for this cleanup! https://codereview.chromium.org/332303002/diff/20001/gpu/command_buffer/service/gpu_service_test.h File gpu/command_buffer/service/gpu_service_test.h (right): https://codereview.chromium.org/332303002/diff/20001/gpu/command_buffer/service/gpu_service_test.h#newcode21 gpu/command_buffer/service/gpu_service_test.h:21: // Base class for ...
6 years, 6 months ago (2014-06-17 19:12:01 UTC) #2
no sievers
https://codereview.chromium.org/332303002/diff/20001/gpu/command_buffer/service/gpu_service_test.h File gpu/command_buffer/service/gpu_service_test.h (right): https://codereview.chromium.org/332303002/diff/20001/gpu/command_buffer/service/gpu_service_test.h#newcode21 gpu/command_buffer/service/gpu_service_test.h:21: // Base class for tests that need GL bindings. ...
6 years, 6 months ago (2014-06-17 22:29:13 UTC) #3
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 6 months ago (2014-06-17 22:29:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/332303002/40001
6 years, 6 months ago (2014-06-17 22:30:02 UTC) #5
commit-bot: I haz the power
Change committed as 278059
6 years, 6 months ago (2014-06-18 14:42:09 UTC) #6
pfeldman
A revert of this CL has been created in https://codereview.chromium.org/331293005/ by pfeldman@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-18 14:55:21 UTC) #7
brettw
On 2014/06/18 14:55:21, pfeldman wrote: > A revert of this CL has been created in ...
6 years, 6 months ago (2014-06-18 16:55:57 UTC) #8
brettw
Oh, James just landed these tests to GN so this was a midair collision. Sorry ...
6 years, 6 months ago (2014-06-18 17:04:08 UTC) #9
no sievers
6 years, 6 months ago (2014-06-18 18:49:31 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 manually as r278136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698