Issue repaints when offsetFromRenderer changes for any squashed layer.

Issue repaints when offsetFromRenderer changes for any squashed layer.

This is necessary because the coordinate system of the squashing layer may change
w.r.t. a squashed layer, even if the squashed layer's layout position did not change.
For example, a new layer may be added to a squashing layer that expands its bouds to the top
or left.

BUG=383779
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176087

[chrishtr, 2014-06-12 23:49:37]

You'll love this patch. :)

I now see why checking offsetFromRenderer is necessary in some cases.

I also discussed at some length with Enne, Ojan and Levi and
this was the approach that seemed best.

https://codereview.chromium.org/331693004/diff/20001/LayoutTests/compositing/...
File
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint-expected.txt
(right):

https://codereview.chromium.org/331693004/diff/20001/LayoutTests/compositing/...
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint-expected.txt:22:
(rect 0.00 0.00 500.00 500.00)
This second rect would not have been present but for my CL.

[Ian Vollick, 2014-06-13 02:42:48]

I'm a bit biased, but I do love this patch. I just have a couple of questions
about the test.

https://codereview.chromium.org/331693004/diff/40001/LayoutTests/compositing/...
File
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint.html
(right):

https://codereview.chromium.org/331693004/diff/40001/LayoutTests/compositing/...
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint.html:36:
}, 2000);
Oof, that's a very big timeout. Why's this necessary? (Could you do onload =
function() {...} here?)

https://codereview.chromium.org/331693004/diff/40001/Source/core/rendering/co...
File Source/core/rendering/compositing/CompositedLayerMapping.h (right):

https://codereview.chromium.org/331693004/diff/40001/Source/core/rendering/co...
Source/core/rendering/compositing/CompositedLayerMapping.h:59:
GraphicsLayerPaintInfo() : offsetFromRendererSet(false) { }
How would you feel about adding an initializer for isBackgroundLayer and
renderLayer while you're there?

[chrishtr, 2014-06-13 04:24:24]

https://codereview.chromium.org/331693004/diff/40001/LayoutTests/compositing/...
File
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint.html
(right):

https://codereview.chromium.org/331693004/diff/40001/LayoutTests/compositing/...
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint.html:36:
}, 2000);
On 2014/06/13 02:42:48, Ian Vollick wrote:
> Oof, that's a very big timeout. Why's this necessary? (Could you do onload =
> function() {...} here?)

Ugh, that's me being sloppy. I changed from runAfterDisplay to check something
and forgot to change it back. Done.

https://codereview.chromium.org/331693004/diff/40001/Source/core/rendering/co...
File Source/core/rendering/compositing/CompositedLayerMapping.h (right):

https://codereview.chromium.org/331693004/diff/40001/Source/core/rendering/co...
Source/core/rendering/compositing/CompositedLayerMapping.h:59:
GraphicsLayerPaintInfo() : offsetFromRendererSet(false) { }
On 2014/06/13 02:42:48, Ian Vollick wrote:
> How would you feel about adding an initializer for isBackgroundLayer and
> renderLayer while you're there?

Done.

[Ian Vollick, 2014-06-13 04:25:54]

On 2014/06/13 04:24:24, chrishtr wrote:
>
https://codereview.chromium.org/331693004/diff/40001/LayoutTests/compositing/...
> File
>
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint.html
> (right):
> 
>
https://codereview.chromium.org/331693004/diff/40001/LayoutTests/compositing/...
>
LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint.html:36:
> }, 2000);
> On 2014/06/13 02:42:48, Ian Vollick wrote:
> > Oof, that's a very big timeout. Why's this necessary? (Could you do onload =
> > function() {...} here?)
> 
> Ugh, that's me being sloppy. I changed from runAfterDisplay to check something
> and forgot to change it back. Done.
> 
>
https://codereview.chromium.org/331693004/diff/40001/Source/core/rendering/co...
> File Source/core/rendering/compositing/CompositedLayerMapping.h (right):
> 
>
https://codereview.chromium.org/331693004/diff/40001/Source/core/rendering/co...
> Source/core/rendering/compositing/CompositedLayerMapping.h:59:
> GraphicsLayerPaintInfo() : offsetFromRendererSet(false) { }
> On 2014/06/13 02:42:48, Ian Vollick wrote:
> > How would you feel about adding an initializer for isBackgroundLayer and
> > renderLayer while you're there?
> 
> Done.

Cool, LGTM

[chrishtr, 2014-06-13 04:26:40]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-06-13 04:27:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/331693004/60001

[commit-bot: I haz the power, 2014-06-13 05:28:04]

Change committed as 176087