Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: Source/core/rendering/compositing/CompositedLayerMapping.h

Issue 331693004: Issue repaints when offsetFromRenderer changes for any squashed layer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments by vollick@ Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 30 matching lines...) Expand all
41 struct GraphicsLayerPaintInfo { 41 struct GraphicsLayerPaintInfo {
42 RenderLayer* renderLayer; 42 RenderLayer* renderLayer;
43 43
44 LayoutRect compositedBounds; 44 LayoutRect compositedBounds;
45 45
46 // The clip rect to apply, in the local coordinate space of the squashed lay er, when painting it. 46 // The clip rect to apply, in the local coordinate space of the squashed lay er, when painting it.
47 IntRect localClipRectForSquashedLayer; 47 IntRect localClipRectForSquashedLayer;
48 48
49 // Offset describing where this squashed RenderLayer paints into the shared GraphicsLayer backing. 49 // Offset describing where this squashed RenderLayer paints into the shared GraphicsLayer backing.
50 IntSize offsetFromRenderer; 50 IntSize offsetFromRenderer;
51 bool offsetFromRendererSet;
52
51 LayoutSize subpixelAccumulation; 53 LayoutSize subpixelAccumulation;
52 54
53 GraphicsLayerPaintingPhase paintingPhase; 55 GraphicsLayerPaintingPhase paintingPhase;
54 56
55 bool isBackgroundLayer; 57 bool isBackgroundLayer;
56 58
59 GraphicsLayerPaintInfo() : renderLayer(0), offsetFromRendererSet(false), isB ackgroundLayer(false) { }
60
57 bool isEquivalentForSquashing(const GraphicsLayerPaintInfo& other) 61 bool isEquivalentForSquashing(const GraphicsLayerPaintInfo& other)
58 { 62 {
59 // FIXME: offsetFromRenderer and compositedBounds should not be checked here, because 63 // FIXME: offsetFromRenderer and compositedBounds should not be checked here, because
60 // they are not yet fixed at the time this function is used. 64 // they are not yet fixed at the time this function is used.
61 return renderLayer == other.renderLayer 65 return renderLayer == other.renderLayer
62 && paintingPhase == other.paintingPhase 66 && paintingPhase == other.paintingPhase
63 && isBackgroundLayer == other.isBackgroundLayer; 67 && isBackgroundLayer == other.isBackgroundLayer;
64 } 68 }
65 }; 69 };
66 70
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 bool m_requiresOwnBackingStoreForAncestorReasons : 1; 397 bool m_requiresOwnBackingStoreForAncestorReasons : 1;
394 bool m_canCompositeFilters : 1; 398 bool m_canCompositeFilters : 1;
395 bool m_backgroundLayerPaintsFixedRootBackground : 1; 399 bool m_backgroundLayerPaintsFixedRootBackground : 1;
396 bool m_needToUpdateGraphicsLayer : 1; 400 bool m_needToUpdateGraphicsLayer : 1;
397 bool m_needToUpdateGraphicsLayerOfAllDecendants : 1; 401 bool m_needToUpdateGraphicsLayerOfAllDecendants : 1;
398 }; 402 };
399 403
400 } // namespace WebCore 404 } // namespace WebCore
401 405
402 #endif // CompositedLayerMapping_h 406 #endif // CompositedLayerMapping_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698