Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 331633003: Qualify the generated includes in core (partial). (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, Yoav Weiss, shans, rjwright, aboxhall, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, dmazzoni, apavlov+blink_chromium.org, rwlbuis, darktears, Steve Block, kenneth.christiansen, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Qualify the generated includes in core (partial). This CL takes care the accessibility, animation and css subdirs under core. There's one exception that css/CSSTokenizer-in.cpp didn't change because of a coding style issue. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -119 lines) Patch
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableUnknown.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DocumentAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ElementAnimation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Keyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSTransitionData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/interpolation/StyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/Clipboard.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/AffectedByFocusTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSParserValues.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSVGDocumentValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValuePool.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFace.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/FontSize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/MediaQueryExp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SVGCSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertyShorthandCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleRuleImport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleSheetList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/MediaQueryTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/SizesAttributeParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
c.shu
6 years, 6 months ago (2014-06-12 14:12:00 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-12 15:45:13 UTC) #2
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-12 15:46:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/331633003/1
6 years, 6 months ago (2014-06-12 15:46:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-12 15:51:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 15:51:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16561)
6 years, 6 months ago (2014-06-12 15:51:35 UTC) #7
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-12 16:44:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/331633003/1
6 years, 6 months ago (2014-06-12 16:45:43 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:48:46 UTC) #10
Message was sent while issue was closed.
Change committed as 176036

Powered by Google App Engine
This is Rietveld 408576698