Fix selection rect calculation for inline elements with padding

Fix selection rect calculation for inline elements with padding

Account for border and padding for inline elements when computing the
height for an inline box. While not needed for layout it is critical for
computing the selection rect.

Change InlineFlowBox::placeBoxesInBlockDirection to accurately account
for the border and padding logical height when computing the selection
height just as the logical top border and padding is taken into account
for the logical top.

Unfortunately this requires a new field in RootInlineBox as the line
bottom and selection bottom can be different.

R=leviw@chromium.org
BUG=385540
TEST=fast/text/selection-with-inline-padding.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176566

[eseidel, 2014-06-19 23:01:47]

lgtm

https://codereview.chromium.org/331303004/diff/1/Source/core/rendering/RootIn...
File Source/core/rendering/RootInlineBox.h (right):

https://codereview.chromium.org/331303004/diff/1/Source/core/rendering/RootIn...
Source/core/rendering/RootInlineBox.h:217: LayoutUnit m_selectionBottom;
I wonder how many lines we typically have on a page, since we'll have one
RootInlinebox for each...

[eae, 2014-06-19 23:04:59]

On 2014/06/19 23:01:47, eseidel wrote:
> lgtm
> 
>
https://codereview.chromium.org/331303004/diff/1/Source/core/rendering/RootIn...
> File Source/core/rendering/RootInlineBox.h (right):
> 
>
https://codereview.chromium.org/331303004/diff/1/Source/core/rendering/RootIn...
> Source/core/rendering/RootInlineBox.h:217: LayoutUnit m_selectionBottom;
> I wonder how many lines we typically have on a page, since we'll have one
> RootInlinebox for each...

Quite a few I imagine, luckily the extra field is only needed for RootInlineBox
and not InlineBox...

[leviw_travelin_and_unemployed, 2014-06-19 23:17:05]

lgtm

[eae, 2014-06-20 00:01:04]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-06-20 00:01:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eae@chromium.org/331303004/20001

[commit-bot: I haz the power, 2014-06-20 01:06:17]

Change committed as 176566