LayoutTests/editing/selection/hit-test-on-text-with-line-height.html - Issue 331303004: Fix selection rect calculation for inline elements with padding

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/hit-test-on-text-with-line-height.html

Issue 331303004: Fix selection rect calculation for inline elements with padding (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 <style>	5 <style>

6 #test { width: 300px; font-size: 50px; line-height: 10px; border: solid 1px blac k; padding: 5px; }	6 #test { width: 300px; font-size: 50px; line-height: 10px; border: solid 1px blac k; padding: 5px; }

7 #test span { border: solid 1px red; }	7 #test span { border: solid 1px red; }

8 </style>	8 </style>

9 </head>	9 </head>

10 <body>	10 <body>

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 clickAndVerify('Click after hello', test.offsetLeft + test.offsetWidth - 5, test.offsetTop + test.offsetHeight / 2, 5);	58 clickAndVerify('Click after hello', test.offsetLeft + test.offsetWidth - 5, test.offsetTop + test.offsetHeight / 2, 5);

59 clickAndVerify('Click after hello (top)', test.offsetLeft + test.offsetWidth - 5, test.offsetTop + 1, 5);	59 clickAndVerify('Click after hello (top)', test.offsetLeft + test.offsetWidth - 5, test.offsetTop + 1, 5);

60 clickAndVerify('Click after hello (bottom)', test.offsetLeft + test.offsetWi dth - 5, test.offsetTop + test.offsetHeight - 1, 5);	60 clickAndVerify('Click after hello (bottom)', test.offsetLeft + test.offsetWi dth - 5, test.offsetTop + test.offsetHeight - 1, 5);

61	61

62 debug('');	62 debug('');

63 debug('Click above black box');	63 debug('Click above black box');

64 clickBetweenEachLetterAndVerify(span.offsetTop + 1);	64 clickBetweenEachLetterAndVerify(span.offsetTop + 1);

65	65

66 debug('');	66 debug('');

67 debug('Click below black box');	67 debug('Click below black box');

68 clickBetweenEachLetterAndVerify(span.offsetTop + span.offsetHeight - 1);	68 clickBetweenEachLetterAndVerify(span.offsetTop + span.offsetHeight - 5);

69	69

70 test.style.display = 'none';	70 test.style.display = 'none';

71 }	71 }

72	72

73	73

74 </script>	74 </script>

75 </body>	75 </body>

76 </html>	76 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/text/selection-with-inline-padding.html » ('j') | no next file with comments »