Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Side by Side Diff: Source/core/rendering/InlineFlowBox.h

Issue 331303004: Fix selection rect calculation for inline elements with padding (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 setLogicalWidth(logicalRight - logicalLeft); 183 setLogicalWidth(logicalRight - logicalLeft);
184 if (knownToHaveNoOverflow() && (minLogicalLeft < logicalLeft || maxLogic alRight > logicalRight)) 184 if (knownToHaveNoOverflow() && (minLogicalLeft < logicalLeft || maxLogic alRight > logicalRight))
185 clearKnownToHaveNoOverflow(); 185 clearKnownToHaveNoOverflow();
186 } 186 }
187 187
188 void computeLogicalBoxHeights(RootInlineBox*, LayoutUnit& maxPositionTop, La youtUnit& maxPositionBottom, 188 void computeLogicalBoxHeights(RootInlineBox*, LayoutUnit& maxPositionTop, La youtUnit& maxPositionBottom,
189 int& maxAscent, int& maxDescent, bool& setMaxA scent, bool& setMaxDescent, 189 int& maxAscent, int& maxDescent, bool& setMaxA scent, bool& setMaxDescent,
190 bool strictMode, GlyphOverflowAndFallbackFonts Map&, FontBaseline, VerticalPositionCache&); 190 bool strictMode, GlyphOverflowAndFallbackFonts Map&, FontBaseline, VerticalPositionCache&);
191 void adjustMaxAscentAndDescent(int& maxAscent, int& maxDescent, 191 void adjustMaxAscentAndDescent(int& maxAscent, int& maxDescent,
192 int maxPositionTop, int maxPositionBottom); 192 int maxPositionTop, int maxPositionBottom);
193 void placeBoxesInBlockDirection(LayoutUnit logicalTop, LayoutUnit maxHeight, int maxAscent, bool strictMode, LayoutUnit& lineTop, LayoutUnit& lineBottom, bo ol& setLineTop, 193 void placeBoxesInBlockDirection(LayoutUnit logicalTop, LayoutUnit maxHeight, int maxAscent, bool strictMode, LayoutUnit& lineTop, LayoutUnit& lineBottom, La youtUnit& selectionBottom, bool& setLineTop,
194 LayoutUnit& lineTopIncludingMargins, LayoutU nit& lineBottomIncludingMargins, bool& hasAnnotationsBefore, bool& hasAnnotation sAfter, FontBaseline); 194 LayoutUnit& lineTopIncludingMargins, LayoutU nit& lineBottomIncludingMargins, bool& hasAnnotationsBefore, bool& hasAnnotation sAfter, FontBaseline);
195 void flipLinesInBlockDirection(LayoutUnit lineTop, LayoutUnit lineBottom); 195 void flipLinesInBlockDirection(LayoutUnit lineTop, LayoutUnit lineBottom);
196 bool requiresIdeographicBaseline(const GlyphOverflowAndFallbackFontsMap&) co nst; 196 bool requiresIdeographicBaseline(const GlyphOverflowAndFallbackFontsMap&) co nst;
197 197
198 LayoutUnit computeOverAnnotationAdjustment(LayoutUnit allowedPosition) const ; 198 LayoutUnit computeOverAnnotationAdjustment(LayoutUnit allowedPosition) const ;
199 LayoutUnit computeUnderAnnotationAdjustment(LayoutUnit allowedPosition) cons t; 199 LayoutUnit computeUnderAnnotationAdjustment(LayoutUnit allowedPosition) cons t;
200 200
201 void computeOverflow(LayoutUnit lineTop, LayoutUnit lineBottom, GlyphOverflo wAndFallbackFontsMap&); 201 void computeOverflow(LayoutUnit lineTop, LayoutUnit lineBottom, GlyphOverflo wAndFallbackFontsMap&);
202 202
203 void removeChild(InlineBox* child, MarkLineBoxes); 203 void removeChild(InlineBox* child, MarkLineBoxes);
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 } 371 }
372 372
373 } // namespace WebCore 373 } // namespace WebCore
374 374
375 #ifndef NDEBUG 375 #ifndef NDEBUG
376 // Outside the WebCore namespace for ease of invocation from gdb. 376 // Outside the WebCore namespace for ease of invocation from gdb.
377 void showTree(const WebCore::InlineFlowBox*); 377 void showTree(const WebCore::InlineFlowBox*);
378 #endif 378 #endif
379 379
380 #endif // InlineFlowBox_h 380 #endif // InlineFlowBox_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/text/selection-with-inline-padding-expected.html ('k') | Source/core/rendering/InlineFlowBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698