Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 331293003: Add common GLFence::IsSupported() check (Closed)

Created:
6 years, 6 months ago by no sievers
Modified:
6 years, 6 months ago
Reviewers:
reveman
CC:
chromium-reviews, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add common GLFence::IsSupported() check Cconsolidate the logic inside gl_fence.cc to allow checking if a GLFence can be created. R=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278860

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment, override GL version and extensions #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -35 lines) Patch
M gpu/command_buffer/service/feature_info.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 2 8 chunks +35 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gpu_service_test.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_service_test.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M ui/gl/gl_fence.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_fence.cc View 1 6 chunks +35 lines, -21 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
no sievers
ptal. Recent fence blacklisting broke the incomplete checks in mailbox_synchronizer.cc and texture_definition.cc (they were only ...
6 years, 6 months ago (2014-06-16 22:43:54 UTC) #1
reveman
lgtm https://codereview.chromium.org/331293003/diff/1/ui/gl/gl_fence.cc File ui/gl/gl_fence.cc (right): https://codereview.chromium.org/331293003/diff/1/ui/gl/gl_fence.cc#newcode180 ui/gl/gl_fence.cc:180: DCHECK(!!fence.get() == GLFence::IsSupported()); DCHECK_EQ?
6 years, 6 months ago (2014-06-17 00:50:05 UTC) #2
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 6 months ago (2014-06-20 20:17:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/331293003/80001
6 years, 6 months ago (2014-06-20 20:20:59 UTC) #4
no sievers
6 years, 6 months ago (2014-06-20 23:33:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 manually as r278860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698