Improve the compositing reasons when squashing fails

Improve the compositing reasons when squashing fails

Currently we just report that "no squashing target was found". There
are many reasons why squashing might fail and this message is not very
informative. This cl expands the list of squashing-related compositing
reasons to make diagnosing layer explosions easier.

R=chrishtr@chromium.org
BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176259

[chrishtr, 2014-06-16 17:11:06]

https://codereview.chromium.org/331203003/diff/1/Source/core/rendering/compos...
File Source/core/rendering/compositing/CompositingLayerAssigner.cpp (right):

https://codereview.chromium.org/331203003/diff/1/Source/core/rendering/compos...
Source/core/rendering/compositing/CompositingLayerAssigner.cpp:144: return
CompositingReasonSquashingClippingContainerMismatch;
Not quite accurate. Make another enum value.

[Ian Vollick, 2014-06-16 17:32:07]

https://codereview.chromium.org/331203003/diff/1/Source/core/rendering/compos...
File Source/core/rendering/compositing/CompositingLayerAssigner.cpp (right):

https://codereview.chromium.org/331203003/diff/1/Source/core/rendering/compos...
Source/core/rendering/compositing/CompositingLayerAssigner.cpp:144: return
CompositingReasonSquashingClippingContainerMismatch;
On 2014/06/16 17:11:05, chrishtr wrote:
> Not quite accurate. Make another enum value.

Done.

[chrishtr, 2014-06-16 17:41:38]

lgtm

[commit-bot: I haz the power, 2014-06-16 17:42:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vollick@chromium.org/331203003/40001

[commit-bot: I haz the power, 2014-06-16 22:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 22:30:13]

Failed to apply patch for Source/platform/graphics/CompositingReasons.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/graphics/CompositingReasons.h
  Hunk #1 FAILED at 10.
  Hunk #2 succeeded at 103 (offset 1 line).
  Hunk #3 succeeded at 207 (offset 1 line).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/platform/graphics/CompositingReasons.h.rej

Patch:       Source/platform/graphics/CompositingReasons.h
Index: Source/platform/graphics/CompositingReasons.h
diff --git a/Source/platform/graphics/CompositingReasons.h
b/Source/platform/graphics/CompositingReasons.h
index
3111cfa1c65f29d56af7dde3bd8c02063e096ba3..47112390a45fd3e0e0dc87d559648ae027692fbb
100644
--- a/Source/platform/graphics/CompositingReasons.h
+++ b/Source/platform/graphics/CompositingReasons.h
@@ -10,66 +10,74 @@
 
 namespace WebCore {
 
-const uint64_t CompositingReasonNone                                   = 0;
-const uint64_t CompositingReasonAll                                    =
~static_cast<uint64_t>(0);
+const uint64_t CompositingReasonNone                                     = 0;
+const uint64_t CompositingReasonAll                                      =
~static_cast<uint64_t>(0);
 
 // Intrinsic reasons that can be known right away by the layer
-const uint64_t CompositingReason3DTransform                            =
UINT64_C(1) << 0;
-const uint64_t CompositingReasonVideo                                  =
UINT64_C(1) << 1;
-const uint64_t CompositingReasonCanvas                                 =
UINT64_C(1) << 2;
-const uint64_t CompositingReasonPlugin                                 =
UINT64_C(1) << 3;
-const uint64_t CompositingReasonIFrame                                 =
UINT64_C(1) << 4;
-const uint64_t CompositingReasonBackfaceVisibilityHidden               =
UINT64_C(1) << 5;
-const uint64_t CompositingReasonActiveAnimation                        =
UINT64_C(1) << 6;
-const uint64_t CompositingReasonTransitionProperty                     =
UINT64_C(1) << 7;
-const uint64_t CompositingReasonFilters                                =
UINT64_C(1) << 8;
-const uint64_t CompositingReasonPositionFixed                          =
UINT64_C(1) << 9;
+const uint64_t CompositingReason3DTransform                              =
UINT64_C(1) << 0;
+const uint64_t CompositingReasonVideo                                    =
UINT64_C(1) << 1;
+const uint64_t CompositingReasonCanvas                                   =
UINT64_C(1) << 2;
+const uint64_t CompositingReasonPlugin                                   =
UINT64_C(1) << 3;
+const uint64_t CompositingReasonIFrame                                   =
UINT64_C(1) << 4;
+const uint64_t CompositingReasonBackfaceVisibilityHidden                 =
UINT64_C(1) << 5;
+const uint64_t CompositingReasonActiveAnimation                          =
UINT64_C(1) << 6;
+const uint64_t CompositingReasonTransitionProperty                       =
UINT64_C(1) << 7;
+const uint64_t CompositingReasonFilters                                  =
UINT64_C(1) << 8;
+const uint64_t CompositingReasonPositionFixed                            =
UINT64_C(1) << 9;
 // Bit 10 is available.
-const uint64_t CompositingReasonOverflowScrollingTouch                 =
UINT64_C(1) << 11;
-const uint64_t CompositingReasonOverflowScrollingParent                =
UINT64_C(1) << 12;
-const uint64_t CompositingReasonOutOfFlowClipping                      =
UINT64_C(1) << 13;
-const uint64_t CompositingReasonVideoOverlay                           =
UINT64_C(1) << 14;
-const uint64_t CompositingReasonWillChangeCompositingHint              =
UINT64_C(1) << 15;
+const uint64_t CompositingReasonOverflowScrollingTouch                   =
UINT64_C(1) << 11;
+const uint64_t CompositingReasonOverflowScrollingParent                  =
UINT64_C(1) << 12;
+const uint64_t CompositingReasonOutOfFlowClipping                        =
UINT64_C(1) << 13;
+const uint64_t CompositingReasonVideoOverlay                             =
UINT64_C(1) << 14;
+const uint64_t CompositingReasonWillChangeCompositingHint                =
UINT64_C(1) << 15;
 // Bit 16 is available.
 
 // Overlap reasons that require knowing what's behind you in paint-order before
knowing the answer
-const uint64_t CompositingReasonAssumedOverlap                         =
UINT64_C(1) << 17;
-const uint64_t CompositingReasonOverlap                                =
UINT64_C(1) << 18;
-const uint64_t CompositingReasonNegativeZIndexChildren                 =
UINT64_C(1) << 19;
-const uint64_t CompositingReasonNoSquashingTargetFound                 =
UINT64_C(1) << 20;
+const uint64_t CompositingReasonAssumedOverlap                           =
UINT64_C(1) << 17;
+const uint64_t CompositingReasonOverlap                                  =
UINT64_C(1) << 18;
+const uint64_t CompositingReasonNegativeZIndexChildren                   =
UINT64_C(1) << 19;
+const uint64_t CompositingReasonScrollsWithRespectToSquashingLayer       =
UINT64_C(1) << 20;
+const uint64_t CompositingReasonSquashingSparsityExceeded                =
UINT64_C(1) << 21;
+const uint64_t CompositingReasonSquashingClippingContainerMismatch       =
UINT64_C(1) << 22;
+const uint64_t CompositingReasonSquashingOpacityAncestorMismatch         =
UINT64_C(1) << 23;
+const uint64_t CompositingReasonSquashingTransformAncestorMismatch       =
UINT64_C(1) << 24;
+const uint64_t CompositingReasonSquashingFilterAncestorMismatch          =
UINT64_C(1) << 25;
+const uint64_t CompositingReasonSquashingWouldBreakPaintOrder            =
UINT64_C(1) << 26;
+const uint64_t CompositingReasonSquashingVideoIsDisallowed               =
UINT64_C(1) << 27;
+const uint64_t CompositingReasonSquashedLayerClipsCompositingDescendants =
UINT64_C(1) << 28;
 
 // Subtree reasons that require knowing what the status of your subtree is
before knowing the answer
-const uint64_t CompositingReasonTransformWithCompositedDescendants     =
UINT64_C(1) << 21;
-const uint64_t CompositingReasonOpacityWithCompositedDescendants       =
UINT64_C(1) << 22;
-const uint64_t CompositingReasonMaskWithCompositedDescendants          =
UINT64_C(1) << 23;
-const uint64_t CompositingReasonReflectionWithCompositedDescendants    =
UINT64_C(1) << 24;
-const uint64_t CompositingReasonFilterWithCompositedDescendants        =
UINT64_C(1) << 25;
-const uint64_t CompositingReasonBlendingWithCompositedDescendants      =
UINT64_C(1) << 26;
-const uint64_t CompositingReasonClipsCompositingDescendants            =
UINT64_C(1) << 27;
-const uint64_t CompositingReasonPerspectiveWith3DDescendants           =
UINT64_C(1) << 28;
-const uint64_t CompositingReasonPreserve3DWith3DDescendants            =
UINT64_C(1) << 29;
-const uint64_t CompositingReasonReflectionOfCompositedParent           =
UINT64_C(1) << 30;
-const uint64_t CompositingReasonIsolateCompositedDescendants           =
UINT64_C(1) << 31;
+const uint64_t CompositingReasonTransformWithCompositedDescendants       =
UINT64_C(1) << 29;
+const uint64_t CompositingReasonOpacityWithCompositedDescendants         =
UINT64_C(1) << 30;
+const uint64_t CompositingReasonMaskWithCompositedDescendants            =
UINT64_C(1) << 31;
+const uint64_t CompositingReasonReflectionWithCompositedDescendants      =
UINT64_C(1) << 32;
+const uint64_t CompositingReasonFilterWithCompositedDescendants          =
UINT64_C(1) << 33;
+const uint64_t CompositingReasonBlendingWithCompositedDescendants        =
UINT64_C(1) << 34;
+const uint64_t CompositingReasonClipsCompositingDescendants              =
UINT64_C(1) << 35;
+const uint64_t CompositingReasonPerspectiveWith3DDescendants             =
UINT64_C(1) << 36;
+const uint64_t CompositingReasonPreserve3DWith3DDescendants              =
UINT64_C(1) << 37;
+const uint64_t CompositingReasonReflectionOfCompositedParent             =
UINT64_C(1) << 38;
+const uint64_t CompositingReasonIsolateCompositedDescendants             =
UINT64_C(1) << 39;
 
 // The root layer is a special case that may be forced to be a layer, but also
it needs to be
 // a layer if anything else in the subtree is composited.
-const uint64_t CompositingReasonRoot                                   =
UINT64_C(1) << 32;
+const uint64_t CompositingReasonRoot                                     =
UINT64_C(1) << 40;
 
 // CompositedLayerMapping internal hierarchy reasons
-const uint64_t CompositingReasonLayerForAncestorClip                   =
UINT64_C(1) << 33;
-const uint64_t CompositingReasonLayerForDescendantClip                 =
UINT64_C(1) << 34;
-const uint64_t CompositingReasonLayerForPerspective                    =
UINT64_C(1) << 35;
-const uint64_t CompositingReasonLayerForHorizontalScrollbar            =
UINT64_C(1) << 36;
-const uint64_t CompositingReasonLayerForVerticalScrollbar              =
UINT64_C(1) << 37;
-const uint64_t CompositingReasonLayerForScrollCorner                   =
UINT64_C(1) << 38;
-const uint64_t CompositingReasonLayerForScrollingContents              =
UINT64_C(1) << 39;
-const uint64_t CompositingReasonLayerForScrollingContainer             =
UINT64_C(1) << 40;
-const uint64_t CompositingReasonLayerForSquashingContents              =
UINT64_C(1) << 41;
-const uint64_t CompositingReasonLayerForSquashingContainer             =
UINT64_C(1) << 42;
-const uint64_t CompositingReasonLayerForForeground                     =
UINT64_C(1) << 43;
-const uint64_t CompositingReasonLayerForBackground                     =
UINT64_C(1) << 44;
-const uint64_t CompositingReasonLayerForMask                           =
UINT64_C(1) << 45;
-const uint64_t CompositingReasonLayerForClippingMask                   =
UINT64_C(1) << 46;
+const uint64_t CompositingReasonLayerForAncestorClip                     =
UINT64_C(1) << 41;
+const uint64_t CompositingReasonLayerForDescendantClip                   =
UINT64_C(1) << 42;
+const uint64_t CompositingReasonLayerForPerspective                      =
UINT64_C(1) << 43;
+const uint64_t CompositingReasonLayerForHorizo…
(message too large)

[Ian Vollick, 2014-06-16 23:29:20]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2014-06-16 23:29:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vollick@chromium.org/331203003/60001

[commit-bot: I haz the power, 2014-06-17 00:53:01]

Change committed as 176259