Rely on Service.Visible instead of Manager.Services

chromeos/dbus/shill_service_client.h

Index: chromeos/dbus/shill_service_client.h
diff --git a/chromeos/dbus/shill_service_client.h b/chromeos/dbus/shill_service_client.h
index 40507fea8b7be2d99111b04d6f888ea690720058..e8b950fd5fc6eca506927caaf1f5f399f3318055 100644
--- a/chromeos/dbus/shill_service_client.h
+++ b/chromeos/dbus/shill_service_client.h
@@ -48,14 +48,23 @@ class CHROMEOS_EXPORT ShillServiceClient : public DBusClient {
                             const std::string& name,
                             const std::string& type,
                             const std::string& state,
-                            bool add_to_visible_list) = 0;
+                            bool visible) = 0;
     virtual void AddServiceWithIPConfig(const std::string& service_path,
                                         const std::string& guid,
                                         const std::string& name,
                                         const std::string& type,
                                         const std::string& state,
                                         const std::string& ipconfig_path,
-                                        bool add_to_visible_list) = 0;
+                                        bool visible) = 0;
+    // Sets the properties for a service but does not add it to the Manager
+    // or Profile. Returns the properties for the service.

[pneubeck (no reviews), 2014/06/17 15:30:33]

for clarification, maybe add a sentence:
"Afterwards, the caller is responsible to [or "should"] add the service using
the Manager's AddManagerService method."

+    virtual base::DictionaryValue* SetServiceProperties(
+        const std::string& service_path,
+        const std::string& guid,
+        const std::string& name,
+        const std::string& type,
+        const std::string& state,
+        bool visible) = 0;
 
     // Removes a Service to the Manager and Service stubs.
     virtual void RemoveService(const std::string& service_path) = 0;