Rely on Service.Visible instead of Manager.Services

chromeos/dbus/shill_service_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_
 #define CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 30 matching lines @@
 
   // Interface for setting up services for testing. Accessed through
   // GetTestInterface(), only implemented in the stub implementation.
   class TestInterface {
    public:
     // Adds a Service to the Manager and Service stubs.
     virtual void AddService(const std::string& service_path,
                             const std::string& name,
                             const std::string& type,
                             const std::string& state,
-                            bool add_to_visible_list) = 0;
+                            bool visible) = 0;
     virtual void AddServiceWithIPConfig(const std::string& service_path,
                                         const std::string& guid,
                                         const std::string& name,
                                         const std::string& type,
                                         const std::string& state,
                                         const std::string& ipconfig_path,
-                                        bool add_to_visible_list) = 0;
+                                        bool visible) = 0;
+    // Sets the properties for a service but does not add it to the Manager
+    // or Profile. Returns the properties for the service.

[pneubeck (no reviews), 2014/06/17 15:30:33]

for clarification, maybe add a sentence:
"Afterwards, the caller is responsible to [or "should"] add the service using
the Manager's AddManagerService method."

+    virtual base::DictionaryValue* SetServiceProperties(
+        const std::string& service_path,
+        const std::string& guid,
+        const std::string& name,
+        const std::string& type,
+        const std::string& state,
+        bool visible) = 0;
 
     // Removes a Service to the Manager and Service stubs.
     virtual void RemoveService(const std::string& service_path) = 0;
 
     // Returns false if a Service matching |service_path| does not exist.
     virtual bool SetServiceProperty(const std::string& service_path,
                                     const std::string& property,
                                     const base::Value& value) = 0;
 
     // Returns properties for |service_path| or NULL if no Service matches.
@@ skipping 107 matching lines @@
   // Create() should be used instead.
   ShillServiceClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShillServiceClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_