chromeos/dbus/shill_manager_client.h - Issue 330833003: Rely on Service.Visible instead of Manager.Services

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_manager_client.h

Issue 330833003: Rely on Service.Visible instead of Manager.Services (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sort services when updated, add test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_manager_client.h

diff --git a/chromeos/dbus/shill_manager_client.h b/chromeos/dbus/shill_manager_client.h

index 23ca24a18b3bcbfdc2a2a810ed4c85bd331dbe5e..9b9541dadfb1377058733cf458190f9dacc871a3 100644

--- a/chromeos/dbus/shill_manager_client.h

+++ b/chromeos/dbus/shill_manager_client.h

@@ -62,7 +62,8 @@ class CHROMEOS_EXPORT ShillManagerClient : public DBusClient {

const base::Value& value) = 0;

// Modify services in the Manager's list.

- virtual void AddManagerService(const std::string& service_path) = 0;

+ virtual void AddManagerService(const std::string& service_path,

+ bool notify_observers) = 0;

virtual void RemoveManagerService(const std::string& service_path) = 0;

virtual void ClearManagerServices() = 0;