Rename FORCE_DETERMINISTIC_BUILD to DONT_EMBED_BUILD_METADATA.

Rename FORCE_DETERMINISTIC_BUILD to DONT_EMBED_BUILD_METADATA.

Strictly speaking this flag isn't here to force a deterministic build, it's here to help us to make sure that no build metadata ends up in the build artifacts to help us guarantee a deterministic build.

(See the discussion in https://codereview.chromium.org/324403006/ for more details)

On the other hand we may have issues with absolute path in __FILE__ and whatever
unforeseen C++ issue. This would require #ifdef'ing them out. This is not
something devs would want to do normally so this flag is off by default.

Eventually we'll want to fix the build system to not have to hack __FILE__ out
by ensuring they are *always* relative paths but until then, this variable can
be used to make progress


R=maruel@chromium.org, thakis@chromium.org
TBR=brettw@chromium.org

BUG=314403
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278053

[Sébastien Marchand, 2014-06-13 13:57:30]

PTAL.

[M-A Ruel, 2014-06-13 14:04:38]

lgtm.

FTR, Nico said he'll take care of getting rid of __DATE__ and __TIME__ so this
new define will not be necessary for that.

On the other hand we may have issues with absolute path in __FILE__ and whatever
unforeseen C++ issue. This would require #ifdef'ing them out. This is not
something devs would want to do normally so this flag is off by default.

Eventually we'll want to fix the build system to not have to hack __FILE__ out
by ensuring they are *always* relative paths but until then, this variable can
be used to make progress.

[Sébastien Marchand, 2014-06-13 16:05:08]

+brettw@ for owner approval.

[Sébastien Marchand, 2014-06-18 00:10:30]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-06-18 00:12:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/330813003/20001

[commit-bot: I haz the power, 2014-06-18 13:10:09]

Change committed as 278053