Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: build/config/BUILD.gn

Issue 330813003: Rename FORCE_DETERMINISTIC_BUILD to DONT_EMBED_BUILD_METADATA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index e803ae3d10318a84d8ee588a99b17c01af0f256d..71137f1ecc816774c3a0b5b7ee15a93d842ff3bb 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -13,11 +13,11 @@ declare_args() {
# catching bugs but in some cases may cause conflicts or excessive slowness.
disable_iterator_debugging = false
- # Set to true to force deterministic builds (this isn't working yet but this
- # flag will help us to get there). See http://crbug.com/314403.
- # TODO(sebmarchand): Update this comment once this flag guarantee a
- # deterministic build.
- force_deterministic_build = false
+ # Set to true to not store any build metadata (this isn't working yet but
+ # this flag will help us to get there). See http://crbug.com/314403.
+ # TODO(sebmarchand): Update this comment once this flag guarantee that
+ # there's no build metadata in the build artifacts.
+ dont_embed_build_metadata = false
}
# TODO(brettw) Most of these should be removed. Instead of global feature
@@ -77,8 +77,8 @@ config("feature_flags") {
if (enable_spellcheck) {
defines += [ "ENABLE_SPELLCHECK=1" ]
}
- if (force_deterministic_build) {
- defines += [ "FORCE_DETERMINISTIC_BUILD" ]
+ if (dont_embed_build_metadata) {
+ defines += [ "DONT_EMBED_BUILD_METADATA" ]
}
if (use_udev) {
# TODO(brettw) should probably be "=1".
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698