Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: build/common.gypi

Issue 330813003: Rename FORCE_DETERMINISTIC_BUILD to DONT_EMBED_BUILD_METADATA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 3bfc9e15e3284db7dc9ffe5a47c97d9b97b4e047..4b26a0a3e93d33012175507cf2529fab3f906cb2 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -271,11 +271,11 @@
# on compile-only bots).
'fastbuild%': 0,
- # Set to 1 to force deterministic builds (this isn't working yet but this
- # flag will help us to get there). See http://crbug.com/314403.
- # TODO(sebmarchand): Update this comment once this flag guarantee a
- # deterministic build.
- 'force_deterministic_build%': 0,
+ # Set to 1 to not store any build metadata (this isn't working yet but
+ # this flag will help us to get there). See http://crbug.com/314403.
+ # TODO(sebmarchand): Update this comment once this flag guarantee that
+ # there's no build metadata in the build artifacts.
+ 'dont_embed_build_metadata%': 0,
# Set to 1 to force Visual C++ to use legacy debug information format /Z7.
# This is useful for parallel compilation tools which can't support /Zi.
@@ -1026,7 +1026,7 @@
'use_xi2_mt%':'<(use_xi2_mt)',
'image_loader_extension%': '<(image_loader_extension)',
'fastbuild%': '<(fastbuild)',
- 'force_deterministic_build%': '<(force_deterministic_build)',
+ 'dont_embed_build_metadata%': '<(dont_embed_build_metadata)',
'win_z7%': '<(win_z7)',
'dcheck_always_on%': '<(dcheck_always_on)',
'tracing_like_official_build%': '<(tracing_like_official_build)',
@@ -2573,11 +2573,11 @@
}], # clang!=1
],
}], # fastbuild!=0
- ['force_deterministic_build==1', {
+ ['dont_embed_build_metadata==1', {
'defines': [
- 'FORCE_DETERMINISTIC_BUILD',
+ 'DONT_EMBED_BUILD_METADATA',
],
- }], # force_deterministic_build==1
+ }], # dont_embed_build_metadata==1
['dcheck_always_on!=0', {
'defines': ['DCHECK_ALWAYS_ON=1'],
}], # dcheck_always_on!=0
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698