Renaming didNavigate() to continueProgram

Renaming didNavigate() to continueProgram

There was a TODO to rename didNavigate() to continueProgram upstream.
As the changes were on both chrome and blink side hence uploading separate patches for the same.

This patch deals with chromium side change.

Link to blink patch : https://codereview.chromium.org/330603003/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279523

[yurys, 2014-06-16 07:22:18]

lgtm

https://codereview.chromium.org/330663002/diff/1/content/renderer/devtools/de...
File content/renderer/devtools/devtools_agent.cc (left):

https://codereview.chromium.org/330663002/diff/1/content/renderer/devtools/de...
content/renderer/devtools/devtools_agent.cc:355: // That is in fact the purpose
of the signal.
Please remove remaining part of the comment too.

[yurys, 2014-06-16 07:24:30]

Blink side change will have two be two step though, you will first need to
introduce WebDevToolsAgent::continueProgram which would delegete to didNavigate,
then after Blink roll land this CL, and only after that remove
WebDevToolsAgent::continueProgram

[suyash, 2014-06-16 09:06:54]

On 2014/06/16 07:24:30, yurys wrote:
> Blink side change will have two be two step though, you will first need to
> introduce WebDevToolsAgent::continueProgram which would delegete to
didNavigate,
> then after Blink roll land this CL, and only after that remove
> WebDevToolsAgent::continueProgram

Thanks for the review :)

Okay. I will break these two patch into a 3 patch submission. Will land the
blink patch before merging the chromium side changes.

[suyash, 2014-06-16 10:15:43]

Uploaded the new patch set addressing the comments.
Will wait for the blink patch to land first

[suyash, 2014-06-18 09:58:54]

Gentle ping!

[abarth-chromium, 2014-06-18 23:34:09]

On 2014/06/18 at 09:58:54, suyash.s wrote:
> Gentle ping!

Who are you pinging?

[suyash, 2014-06-19 09:30:03]

On 2014/06/18 23:34:09, abarth wrote:
> On 2014/06/18 at 09:58:54, suyash.s wrote:
> > Gentle ping!
> 
> Who are you pinging?

I would actually require an owners' review for this patch. So ping to the
reviewers I added.
It would be great if you can review it.

[yurys, 2014-06-19 10:24:39]

On 2014/06/19 09:30:03, suyash wrote:
> On 2014/06/18 23:34:09, abarth wrote:
> > On 2014/06/18 at 09:58:54, suyash.s wrote:
> > > Gentle ping!
> > 
> > Who are you pinging?
> 
> I would actually require an owners' review for this patch. So ping to the
> reviewers I added.
> It would be great if you can review it.

You already have owner review (I'm an owner of .../devtools/)

[suyash, 2014-06-19 11:35:43]

On 2014/06/19 10:24:39, yurys wrote:
> On 2014/06/19 09:30:03, suyash wrote:
> > On 2014/06/18 23:34:09, abarth wrote:
> > > On 2014/06/18 at 09:58:54, suyash.s wrote:
> > > > Gentle ping!
> > > 
> > > Who are you pinging?
> > 
> > I would actually require an owners' review for this patch. So ping to the
> > reviewers I added.
> > It would be great if you can review it.
> 
> You already have owner review (I'm an owner of .../devtools/)

Oh my bad yurys! Thanks :)

[suyash, 2014-06-23 07:45:55]

The CQ bit was checked by suyash.s@samsung.com

[commit-bot: I haz the power, 2014-06-23 07:46:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/suyash.s@samsung.com/330663002/20001

[suyash, 2014-06-23 07:53:39]

The CQ bit was unchecked by suyash.s@samsung.com

[suyash, 2014-06-23 13:50:06]

The CQ bit was checked by suyash.s@samsung.com

[suyash, 2014-06-23 13:50:21]

The CQ bit was unchecked by suyash.s@samsung.com

[suyash, 2014-06-24 19:34:27]

The CQ bit was checked by suyash.s@samsung.com

[commit-bot: I haz the power, 2014-06-24 19:36:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/suyash.s@samsung.com/330663002/20001

[commit-bot: I haz the power, 2014-06-24 22:52:52]

Change committed as 279523