Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 330603003: Renaming didNavigate to continueProgram (Closed)

Created:
6 years, 6 months ago by suyash
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Renaming didNavigate to continueProgram There was a TODO to rename didNavigate() to continueProgram upstream. As the changes were on both chrome and blink side hence uploading separate patches for the same. This patch deals with blink side change. Link to chromium patch : https://codereview.chromium.org/330663002/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176727

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/web/WebDevToolsAgentImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebDevToolsAgent.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
yurys
This will break Blink roll, you need to start with adding continueProgram, then switch Chromium ...
6 years, 6 months ago (2014-06-16 07:26:07 UTC) #1
suyash
On 2014/06/16 07:26:07, yurys wrote: > This will break Blink roll, you need to start ...
6 years, 6 months ago (2014-06-16 09:07:34 UTC) #2
suyash
New patch set uploaded. PTAL @yurys. Once it gets landed i will make the necessary ...
6 years, 6 months ago (2014-06-16 09:43:21 UTC) #3
yurys
lgtm
6 years, 6 months ago (2014-06-16 09:49:07 UTC) #4
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 6 months ago (2014-06-16 09:49:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/330603003/20001
6 years, 6 months ago (2014-06-16 09:50:55 UTC) #6
suyash
@yurys Probably it will require an owner's lgtm too.
6 years, 6 months ago (2014-06-16 10:11:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 10:59:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7693)
6 years, 6 months ago (2014-06-16 10:59:03 UTC) #9
suyash
On 2014/06/16 10:59:03, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-18 08:42:26 UTC) #10
pfeldman
lgtm
6 years, 6 months ago (2014-06-18 09:52:47 UTC) #11
suyash
On 2014/06/18 09:52:47, pfeldman wrote: > lgtm Thanks :)
6 years, 6 months ago (2014-06-18 09:58:45 UTC) #12
Inactive
suyash@, could you please remove "upstream" from the CL description and title. I think the ...
6 years, 6 months ago (2014-06-18 13:15:48 UTC) #13
suyash
On 2014/06/18 13:15:48, Chris Dumez wrote: > suyash@, could you please remove "upstream" from the ...
6 years, 6 months ago (2014-06-18 16:04:18 UTC) #14
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 6 months ago (2014-06-20 06:51:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/330603003/20001
6 years, 6 months ago (2014-06-20 06:52:05 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-20 06:58:00 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 07:02:52 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8094)
6 years, 6 months ago (2014-06-20 07:02:53 UTC) #19
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 6 months ago (2014-06-20 09:36:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/330603003/20001
6 years, 6 months ago (2014-06-20 09:37:01 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-20 09:41:48 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 09:45:38 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8110)
6 years, 6 months ago (2014-06-20 09:45:39 UTC) #24
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 6 months ago (2014-06-23 06:40:57 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/330603003/40001
6 years, 6 months ago (2014-06-23 06:41:53 UTC) #26
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 07:42:53 UTC) #27
Message was sent while issue was closed.
Change committed as 176727

Powered by Google App Engine
This is Rietveld 408576698