content/renderer/devtools/devtools_agent.cc - Issue 330663002: Renaming didNavigate() to continueProgram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 330663002: Renaming didNavigate() to continueProgram (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing the comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/devtools/devtools_agent.cc

diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc

index 4341d023203285cee92edebb7ef33fe5d96d2c06..746aec4afa845a47ad4f879652f11df6f96dd0df 100644

--- a/content/renderer/devtools/devtools_agent.cc

+++ b/content/renderer/devtools/devtools_agent.cc

@@ -351,10 +351,8 @@ void DevToolsAgent::OnAddMessageToConsole(ConsoleMessageLevel level,

void DevToolsAgent::ContinueProgram() {

WebDevToolsAgent* web_agent = GetWebAgent();

- // TODO(pfeldman): rename didNavigate to continueProgram upstream.

- // That is in fact the purpose of the signal.

if (web_agent)

- web_agent->didNavigate();

+ web_agent->continueProgram();

}

void DevToolsAgent::OnSetupDevToolsClient() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »