Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 330603004: Rename FaviconBitmapXxx to FaviconRawBitmapXxx (Closed)

Created:
6 years, 6 months ago by oshima
Modified:
6 years, 6 months ago
Reviewers:
pkotwicz, sky
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, sadrul, estade+watch_chromium.org, tfarina, dbeam+watch-ntp_chromium.org, haitaol+watch_chromium.org, browser-components-watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, ben+ash_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename * FaviconBitmapXxx to FaviconRawBitmapXxx * FaviconRawCallback to FaviconRawBitmapCallback * FaviconService::GetXXXForPage to FaviconService::GetXxxcForPageURL BUG=None R=pkotwicz@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277142

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : fix win/android build #

Patch Set 5 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -363 lines) Patch
M chrome/browser/android/favicon_helper.cc View 1 2 3 4 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/shortcut_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_handler.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 11 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/favicon/favicon_service.h View 1 6 chunks +32 lines, -32 lines 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 1 14 chunks +45 lines, -38 lines 0 comments Download
M chrome/browser/favicon/favicon_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor.h View 1 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor.cc View 1 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 2 7 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 15 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 2 35 chunks +44 lines, -44 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 7 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache.cc View 7 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/navigation_popup.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 2 3 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/favicon_base/favicon_callback.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M components/favicon_base/favicon_types.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/favicon_base/favicon_types.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M components/favicon_base/select_favicon_frames.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
oshima
6 years, 6 months ago (2014-06-12 21:20:41 UTC) #1
pkotwicz
Thanks for doing this. I think that renaming favicon_base::FaviconBitmapResult to favicon_base::FaviconRawBitmapResult is useful because it ...
6 years, 6 months ago (2014-06-12 22:48:15 UTC) #2
pkotwicz
https://codereview.chromium.org/330603004/diff/20001/components/favicon_base/select_favicon_frames.h File components/favicon_base/select_favicon_frames.h (right): https://codereview.chromium.org/330603004/diff/20001/components/favicon_base/select_favicon_frames.h#newcode20 components/favicon_base/select_favicon_frames.h:20: // SelectFaviconFrames() or SelectFaviconRawBitmapIDs(). This should be SelectFaviconFrameIndices() SelectFaviconRawBitmapIDs() ...
6 years, 6 months ago (2014-06-12 22:52:02 UTC) #3
oshima
> I think that you should not rename the methods in chrome/browser/history. The > names ...
6 years, 6 months ago (2014-06-12 23:25:44 UTC) #4
pkotwicz
LGTM
6 years, 6 months ago (2014-06-12 23:31:11 UTC) #5
oshima
tbr'ing sky for trivial rename change.
6 years, 6 months ago (2014-06-13 00:02:30 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-13 00:02:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/330603004/40001
6 years, 6 months ago (2014-06-13 00:04:36 UTC) #8
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 6 months ago (2014-06-13 05:31:50 UTC) #9
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-13 14:28:30 UTC) #10
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 6 months ago (2014-06-13 14:28:37 UTC) #11
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-13 21:18:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/330603004/160001
6 years, 6 months ago (2014-06-13 21:21:19 UTC) #13
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-13 23:40:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/330603004/160001
6 years, 6 months ago (2014-06-13 23:43:25 UTC) #15
oshima
6 years, 6 months ago (2014-06-14 00:38:59 UTC) #16
Message was sent while issue was closed. 
Committed patchset #5 manually as r277142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698