Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/browser/history/history_service.cc

Issue 330603004: Rename FaviconBitmapXxx to FaviconRawBitmapXxx (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix android Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/jumplist_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index 1a3ac9ebd178fb01561d9320731ab51407260dd3..9ca4e1ea4304555126e420fbe404a274b2d3a150 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -71,12 +71,13 @@ static const char* kHistoryThreadName = "Chrome_HistoryThread";
void RunWithFaviconResults(
const favicon_base::FaviconResultsCallback& callback,
- std::vector<favicon_base::FaviconBitmapResult>* bitmap_results) {
+ std::vector<favicon_base::FaviconRawBitmapResult>* bitmap_results) {
callback.Run(*bitmap_results);
}
-void RunWithFaviconResult(const favicon_base::FaviconRawCallback& callback,
- favicon_base::FaviconBitmapResult* bitmap_result) {
+void RunWithFaviconResult(
+ const favicon_base::FaviconRawBitmapCallback& callback,
+ favicon_base::FaviconRawBitmapResult* bitmap_result) {
callback.Run(*bitmap_result);
}
@@ -547,8 +548,8 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFavicons(
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- std::vector<favicon_base::FaviconBitmapResult>* results =
- new std::vector<favicon_base::FaviconBitmapResult>();
+ std::vector<favicon_base::FaviconRawBitmapResult>* results =
+ new std::vector<favicon_base::FaviconRawBitmapResult>();
return tracker->PostTaskAndReply(
thread_->message_loop_proxy().get(),
FROM_HERE,
@@ -571,8 +572,8 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFaviconsForURL(
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- std::vector<favicon_base::FaviconBitmapResult>* results =
- new std::vector<favicon_base::FaviconBitmapResult>();
+ std::vector<favicon_base::FaviconRawBitmapResult>* results =
+ new std::vector<favicon_base::FaviconRawBitmapResult>();
return tracker->PostTaskAndReply(
thread_->message_loop_proxy().get(),
FROM_HERE,
@@ -590,12 +591,12 @@ base::CancelableTaskTracker::TaskId HistoryService::GetLargestFaviconForURL(
const GURL& page_url,
const std::vector<int>& icon_types,
int minimum_size_in_pixels,
- const favicon_base::FaviconRawCallback& callback,
+ const favicon_base::FaviconRawBitmapCallback& callback,
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- favicon_base::FaviconBitmapResult* result =
- new favicon_base::FaviconBitmapResult();
+ favicon_base::FaviconRawBitmapResult* result =
+ new favicon_base::FaviconRawBitmapResult();
return tracker->PostTaskAndReply(
thread_->message_loop_proxy().get(),
FROM_HERE,
@@ -616,8 +617,8 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFaviconForID(
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- std::vector<favicon_base::FaviconBitmapResult>* results =
- new std::vector<favicon_base::FaviconBitmapResult>();
+ std::vector<favicon_base::FaviconRawBitmapResult>* results =
+ new std::vector<favicon_base::FaviconRawBitmapResult>();
return tracker->PostTaskAndReply(
thread_->message_loop_proxy().get(),
FROM_HERE,
@@ -641,8 +642,8 @@ HistoryService::UpdateFaviconMappingsAndFetch(
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- std::vector<favicon_base::FaviconBitmapResult>* results =
- new std::vector<favicon_base::FaviconBitmapResult>();
+ std::vector<favicon_base::FaviconRawBitmapResult>* results =
+ new std::vector<favicon_base::FaviconRawBitmapResult>();
return tracker->PostTaskAndReply(
thread_->message_loop_proxy().get(),
FROM_HERE,
@@ -674,7 +675,8 @@ void HistoryService::MergeFavicon(
void HistoryService::SetFavicons(
const GURL& page_url,
favicon_base::IconType icon_type,
- const std::vector<favicon_base::FaviconBitmapData>& favicon_bitmap_data) {
+ const std::vector<favicon_base::FaviconRawBitmapData>&
+ favicon_bitmap_data) {
DCHECK(thread_checker_.CalledOnValidThread());
if (!CanAddURL(page_url))
return;
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/jumplist_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698