Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: chrome/browser/sync/glue/favicon_cache_unittest.cc

Issue 330603004: Rename FaviconBitmapXxx to FaviconRawBitmapXxx (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix android Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/glue/favicon_cache.h" 5 #include "chrome/browser/sync/glue/favicon_cache.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 } 404 }
405 405
406 scoped_ptr<syncer::SyncErrorFactory> SyncFaviconCacheTest:: 406 scoped_ptr<syncer::SyncErrorFactory> SyncFaviconCacheTest::
407 CreateAndPassSyncErrorFactory() { 407 CreateAndPassSyncErrorFactory() {
408 return scoped_ptr<syncer::SyncErrorFactory>( 408 return scoped_ptr<syncer::SyncErrorFactory>(
409 new syncer::SyncErrorFactoryMock()); 409 new syncer::SyncErrorFactoryMock());
410 } 410 }
411 411
412 void SyncFaviconCacheTest::OnCustomFaviconDataAvailable( 412 void SyncFaviconCacheTest::OnCustomFaviconDataAvailable(
413 const TestFaviconData& test_data) { 413 const TestFaviconData& test_data) {
414 std::vector<favicon_base::FaviconBitmapResult> bitmap_results; 414 std::vector<favicon_base::FaviconRawBitmapResult> bitmap_results;
415 if (!test_data.image_16.empty()) { 415 if (!test_data.image_16.empty()) {
416 favicon_base::FaviconBitmapResult bitmap_result; 416 favicon_base::FaviconRawBitmapResult bitmap_result;
417 bitmap_result.icon_url = test_data.icon_url; 417 bitmap_result.icon_url = test_data.icon_url;
418 bitmap_result.pixel_size.set_width(16); 418 bitmap_result.pixel_size.set_width(16);
419 bitmap_result.pixel_size.set_height(16); 419 bitmap_result.pixel_size.set_height(16);
420 base::RefCountedString* temp_string = new base::RefCountedString(); 420 base::RefCountedString* temp_string = new base::RefCountedString();
421 temp_string->data() = test_data.image_16; 421 temp_string->data() = test_data.image_16;
422 bitmap_result.bitmap_data = temp_string; 422 bitmap_result.bitmap_data = temp_string;
423 bitmap_results.push_back(bitmap_result); 423 bitmap_results.push_back(bitmap_result);
424 } 424 }
425 if (!test_data.image_32.empty()) { 425 if (!test_data.image_32.empty()) {
426 favicon_base::FaviconBitmapResult bitmap_result; 426 favicon_base::FaviconRawBitmapResult bitmap_result;
427 bitmap_result.icon_url = test_data.icon_url; 427 bitmap_result.icon_url = test_data.icon_url;
428 bitmap_result.pixel_size.set_width(32); 428 bitmap_result.pixel_size.set_width(32);
429 bitmap_result.pixel_size.set_height(32); 429 bitmap_result.pixel_size.set_height(32);
430 base::RefCountedString* temp_string = new base::RefCountedString(); 430 base::RefCountedString* temp_string = new base::RefCountedString();
431 temp_string->data() = test_data.image_32; 431 temp_string->data() = test_data.image_32;
432 bitmap_result.bitmap_data = temp_string; 432 bitmap_result.bitmap_data = temp_string;
433 bitmap_results.push_back(bitmap_result); 433 bitmap_results.push_back(bitmap_result);
434 } 434 }
435 if (!test_data.image_64.empty()) { 435 if (!test_data.image_64.empty()) {
436 favicon_base::FaviconBitmapResult bitmap_result; 436 favicon_base::FaviconRawBitmapResult bitmap_result;
437 bitmap_result.icon_url = test_data.icon_url; 437 bitmap_result.icon_url = test_data.icon_url;
438 bitmap_result.pixel_size.set_width(64); 438 bitmap_result.pixel_size.set_width(64);
439 bitmap_result.pixel_size.set_height(64); 439 bitmap_result.pixel_size.set_height(64);
440 base::RefCountedString* temp_string = new base::RefCountedString(); 440 base::RefCountedString* temp_string = new base::RefCountedString();
441 temp_string->data() = test_data.image_64; 441 temp_string->data() = test_data.image_64;
442 bitmap_result.bitmap_data = temp_string; 442 bitmap_result.bitmap_data = temp_string;
443 bitmap_results.push_back(bitmap_result); 443 bitmap_results.push_back(bitmap_result);
444 } 444 }
445 cache()->OnFaviconDataAvailable(test_data.page_url, bitmap_results); 445 cache()->OnFaviconDataAvailable(test_data.page_url, bitmap_results);
446 } 446 }
(...skipping 1485 matching lines...) Expand 10 before | Expand all | Expand 10 after
1932 EXPECT_EQ(changes[4].change_type(), syncer::SyncChange::ACTION_ADD); 1932 EXPECT_EQ(changes[4].change_type(), syncer::SyncChange::ACTION_ADD);
1933 EXPECT_EQ(changes[4].sync_data().GetDataType(), syncer::FAVICON_TRACKING); 1933 EXPECT_EQ(changes[4].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
1934 EXPECT_EQ(kMaxSyncFavicons, GetFaviconId(changes[4])); 1934 EXPECT_EQ(kMaxSyncFavicons, GetFaviconId(changes[4]));
1935 // Expire tracking for favicon[0]. 1935 // Expire tracking for favicon[0].
1936 EXPECT_EQ(changes[5].change_type(), syncer::SyncChange::ACTION_DELETE); 1936 EXPECT_EQ(changes[5].change_type(), syncer::SyncChange::ACTION_DELETE);
1937 EXPECT_EQ(changes[5].sync_data().GetDataType(), syncer::FAVICON_TRACKING); 1937 EXPECT_EQ(changes[5].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
1938 EXPECT_EQ(0, GetFaviconId(changes[5])); 1938 EXPECT_EQ(0, GetFaviconId(changes[5]));
1939 } 1939 }
1940 1940
1941 } // namespace browser_sync 1941 } // namespace browser_sync
OLDNEW
« no previous file with comments | « chrome/browser/sync/glue/favicon_cache.cc ('k') | chrome/browser/sync/test/integration/bookmarks_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698