Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 330463002: Revert of Enable Oilpan by default in modules/speech/ (Closed)

Created:
6 years, 6 months ago by Pat Meenan
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -120 lines) Patch
M Source/bindings/v8/Dictionary.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 4 chunks +14 lines, -2 lines 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammar.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechGrammar.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechGrammar.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammarList.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 5 chunks +12 lines, -8 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionError.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.h View 4 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.h View 2 chunks +9 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.h View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 3 chunks +9 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SpeechRecognitionClientProxy.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/web/WebSpeechGrammar.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebSpeechRecognitionHandle.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebSpeechRecognitionResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M public/web/WebSpeechGrammar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebSpeechRecognitionHandle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M public/web/WebSpeechRecognitionResult.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Pat Meenan
Created Revert of Enable Oilpan by default in modules/speech/
6 years, 6 months ago (2014-06-11 15:30:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmeenan@chromium.org/330463002/1
6 years, 6 months ago (2014-06-11 15:31:19 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 15:31:20 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-11 15:31:21 UTC) #4
sof
thanks, lgtm
6 years, 6 months ago (2014-06-11 15:31:59 UTC) #5
haraken
LGTM, thanks!
6 years, 6 months ago (2014-06-11 15:41:53 UTC) #6
Pat Meenan
The CQ bit was checked by pmeenan@chromium.org
6 years, 6 months ago (2014-06-11 16:32:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmeenan@chromium.org/330463002/1
6 years, 6 months ago (2014-06-11 16:33:29 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:34:43 UTC) #9
Message was sent while issue was closed.
Change committed as 175965

Powered by Google App Engine
This is Rietveld 408576698