Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 330463002: Revert of Enable Oilpan by default in modules/speech/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/Dictionary.h ('k') | Source/modules/speech/DOMWindowSpeechSynthesis.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/Dictionary.cpp
diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp
index 0b616c90dec547e35ec51aa980ffbbc827e8f123..b742140269634cda5059470d069ac5cb05131d76 100644
--- a/Source/bindings/v8/Dictionary.cpp
+++ b/Source/bindings/v8/Dictionary.cpp
@@ -39,6 +39,7 @@
#include "bindings/modules/v8/V8IDBKeyRange.h"
#include "bindings/modules/v8/V8MIDIPort.h"
#include "bindings/modules/v8/V8MediaStream.h"
+#include "bindings/modules/v8/V8SpeechRecognitionError.h"
#include "bindings/modules/v8/V8SpeechRecognitionResult.h"
#include "bindings/modules/v8/V8SpeechRecognitionResultList.h"
#include "bindings/v8/ArrayValue.h"
@@ -51,6 +52,7 @@
#include "modules/gamepad/Gamepad.h"
#include "modules/indexeddb/IDBKeyRange.h"
#include "modules/mediastream/MediaStream.h"
+#include "modules/speech/SpeechRecognitionError.h"
#include "modules/speech/SpeechRecognitionResult.h"
#include "modules/speech/SpeechRecognitionResultList.h"
#include "wtf/MathExtras.h"
@@ -477,7 +479,17 @@
return true;
}
-bool Dictionary::get(const String& key, Member<SpeechRecognitionResult>& value) const
+bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionError>& value) const
+{
+ v8::Local<v8::Value> v8Value;
+ if (!getKey(key, v8Value))
+ return false;
+
+ value = V8SpeechRecognitionError::toNativeWithTypeCheck(m_isolate, v8Value);
+ return true;
+}
+
+bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionResult>& value) const
{
v8::Local<v8::Value> v8Value;
if (!getKey(key, v8Value))
@@ -487,7 +499,7 @@
return true;
}
-bool Dictionary::get(const String& key, Member<SpeechRecognitionResultList>& value) const
+bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionResultList>& value) const
{
v8::Local<v8::Value> v8Value;
if (!getKey(key, v8Value))
« no previous file with comments | « Source/bindings/v8/Dictionary.h ('k') | Source/modules/speech/DOMWindowSpeechSynthesis.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698