Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
330423004:
Use new common tools in Python scripts (Closed)
DescriptionUse new common tools in Python scripts
BUG=skia:2682
R=rmistry@google.com
Committed: https://skia.googlesource.com/skia/+/bb0ef0a
Patch Set 1 #Patch Set 2 : Pylint #
Total comments: 20
Patch Set 3 : Update DEPS after https://skia.googlesource.com/common/+/767bf85 #Patch Set 4 : Address comments #
Total comments: 4
Patch Set 5 : fix_pythonpath #
Total comments: 2
Patch Set 6 : append #
Messages
Total messages: 15 (0 generated)
Depends on https://codereview.chromium.org/346743008/. https://codereview.chromium.org/330423004/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/330423004/diff/20001/DEPS#newcode6 DEPS:6: "common": "https://skia.googlesource.com/common.git@a50df31f67699199366c04d07b318cde515551bd", Will change this hash once https://codereview.chromium.org/346743008/ is submitted. https://codereview.chromium.org/330423004/diff/20001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/330423004/diff/20001/PRESUBMIT.py#newcode49 PRESUBMIT.py:49: def _PythonChecks(input_api, output_api): Pretty much just copy/pasted from the skia-buildbot PRESUBMIT. https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... File tools/add_codereview_message.py (right): https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... tools/add_codereview_message.py:1: #!/usr/bin/python2 This is greatly simplified through the use of depot_tools' rietveld module. Honestly, this functionality should be added to git_cl as "git cl add-comment"... https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py File tools/fix_pythonpath.py (right): https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:1: #!/usr/bin/env python For convenience. https://codereview.chromium.org/330423004/diff/20001/tools/roll_deps.py File tools/roll_deps.py (right): https://codereview.chromium.org/330423004/diff/20001/tools/roll_deps.py#newcode1 tools/roll_deps.py:1: #!/usr/bin/python2 Lots of changes to this script; adapting to use the new shared utils modules, changing to use pure-git only, and drawing on auto_roll a bit.
https://codereview.chromium.org/330423004/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/330423004/diff/20001/DEPS#newcode6 DEPS:6: "common": "https://skia.googlesource.com/common.git@a50df31f67699199366c04d07b318cde515551bd", On 2014/06/23 20:06:30, borenet wrote: > Will change this hash once https://codereview.chromium.org/346743008/ is > submitted. Done.
https://codereview.chromium.org/330423004/diff/20001/PRESUBMIT.py File PRESUBMIT.py (left): https://codereview.chromium.org/330423004/diff/20001/PRESUBMIT.py#oldcode192 PRESUBMIT.py:192: break; I am unhappy about the removal of my hybrid java + python line. https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... File tools/add_codereview_message.py (right): https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... tools/add_codereview_message.py:26: import fix_pythonpath # pylint: disable=W0611 nit: inline comments should have two spaces from the stmt http://legacy.python.org/dev/peps/pep-0008/#inline-comments https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... tools/add_codereview_message.py:27: from common.py.utils import find_depot_tools # pylint: disable=W0611 Same here. https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... tools/add_codereview_message.py:39: my_rietveld = rietveld.Rietveld('https://codereview.chromium.org', None, Make codereview.chromium.org a constant. What are the other two arguments? can you use named parameters so that it is clear what they are. https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py File tools/fix_pythonpath.py (right): https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:7: """Adjust the PYTHONPATH appropriately.""" What you are doing here is including the root checkout directory in the pythonpath to hopefully make it convenience for modules to import other modules. Can you specify something like that here, the current pydoc is not very clear. https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:20: print 'PYTHONPATH=%s' % ':'.join(sys.path) I am not clear about how this module will be used. Will it be imported by files and get the checkout root added automatically or will something rely on the above printed line to do anything. https://codereview.chromium.org/330423004/diff/20001/tools/git-sync-deps File tools/git-sync-deps (right): https://codereview.chromium.org/330423004/diff/20001/tools/git-sync-deps#newc... tools/git-sync-deps:35: import fix_pythonpath Maybe a more intuitive name will be add_checkout_root_to_path
Uploaded patch set 4. https://codereview.chromium.org/330423004/diff/20001/PRESUBMIT.py File PRESUBMIT.py (left): https://codereview.chromium.org/330423004/diff/20001/PRESUBMIT.py#oldcode192 PRESUBMIT.py:192: break; On 2014/06/24 18:31:04, rmistry wrote: > I am unhappy about the removal of my hybrid java + python line. I'm happy about the PRESUBMIT's self-bootstrapping behavior. https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... File tools/add_codereview_message.py (right): https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... tools/add_codereview_message.py:26: import fix_pythonpath # pylint: disable=W0611 On 2014/06/24 18:31:04, rmistry wrote: > nit: inline comments should have two spaces from the stmt > http://legacy.python.org/dev/peps/pep-0008/#inline-comments Done. https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... tools/add_codereview_message.py:27: from common.py.utils import find_depot_tools # pylint: disable=W0611 On 2014/06/24 18:31:05, rmistry wrote: > Same here. Done. https://codereview.chromium.org/330423004/diff/20001/tools/add_codereview_mes... tools/add_codereview_message.py:39: my_rietveld = rietveld.Rietveld('https://codereview.chromium.org', None, On 2014/06/24 18:31:04, rmistry wrote: > Make http://codereview.chromium.org a constant. > What are the other two arguments? can you use named parameters so that it is > clear what they are. Done. https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py File tools/fix_pythonpath.py (right): https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:7: """Adjust the PYTHONPATH appropriately.""" On 2014/06/24 18:31:05, rmistry wrote: > What you are doing here is including the root checkout directory in the > pythonpath to hopefully make it convenience for modules to import other modules. > Can you specify something like that here, the current pydoc is not very clear. Adjusted the wording but did not specify that the root dir is what's added, since we may add more. https://codereview.chromium.org/330423004/diff/20001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:20: print 'PYTHONPATH=%s' % ':'.join(sys.path) On 2014/06/24 18:31:05, rmistry wrote: > I am not clear about how this module will be used. Will it be imported by files > and get the checkout root added automatically or will something rely on the > above printed line to do anything. I expect that scripts will import it. I added the print just so that if you ran the file directly it would show what its result would have been. https://codereview.chromium.org/330423004/diff/20001/tools/git-sync-deps File tools/git-sync-deps (right): https://codereview.chromium.org/330423004/diff/20001/tools/git-sync-deps#newc... tools/git-sync-deps:35: import fix_pythonpath On 2014/06/24 18:31:05, rmistry wrote: > Maybe a more intuitive name will be add_checkout_root_to_path I'd rather not make it specific to a single directory, in case we add more to it.
https://codereview.chromium.org/330423004/diff/60001/tools/add_codereview_mes... File tools/add_codereview_message.py (right): https://codereview.chromium.org/330423004/diff/60001/tools/add_codereview_mes... tools/add_codereview_message.py:43: # reuse of existing cached credentials. How long do they stay cached? https://codereview.chromium.org/330423004/diff/60001/tools/fix_pythonpath.py File tools/fix_pythonpath.py (right): https://codereview.chromium.org/330423004/diff/60001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:7: """Add commonly-used directories to PYTHONPATH.""" The problem with this module determining which directories need to be added to the pythonpath of all calling modules is that it may result in conflicts or the import of an unintended module. Having only the checkout root added automatically, makes it very obvious what is going on instead of not knowing which directories are going to be magically added. I assume we will want to do something similar in the other two repositories in which case we should come up with a solution for a generic "fix_pythonpath" module here. If we want this module to support more directories than the checkout root then an explicit way of doing this is to add a function here that has the signature 'def append_to_pythonpath(dirs)' Clients would invoke it with constants defined in this file: fix_pythonpath.append_to_pythonpath(fix_pythonpath.CHECKOUT_ROOT, fix_pythonpath.SKIA_SITE_CONFIG_DIR) or maybe CHECKOUT_ROOT is always added to the pythonpath like you currently have, and the append_to_pythonpath function will be used only for additional dirs that callers care about.
https://codereview.chromium.org/330423004/diff/60001/tools/add_codereview_mes... File tools/add_codereview_message.py (right): https://codereview.chromium.org/330423004/diff/60001/tools/add_codereview_mes... tools/add_codereview_message.py:43: # reuse of existing cached credentials. On 2014/06/25 13:56:22, rmistry wrote: > How long do they stay cached? About 2 weeks, I'd guess, based on my experience. This is the same mechanism used when uploading CLs. https://codereview.chromium.org/330423004/diff/60001/tools/fix_pythonpath.py File tools/fix_pythonpath.py (right): https://codereview.chromium.org/330423004/diff/60001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:7: """Add commonly-used directories to PYTHONPATH.""" On 2014/06/25 13:56:22, rmistry wrote: > The problem with this module determining which directories need to be added to > the pythonpath of all calling modules is that it may result in conflicts or the > import of an unintended module. > > Having only the checkout root added automatically, makes it very obvious what is > going on instead of not knowing which directories are going to be magically > added. > > I assume we will want to do something similar in the other two repositories in > which case we should come up with a solution for a generic "fix_pythonpath" > module here. > > If we want this module to support more directories than the checkout root then > an explicit way of doing this is to add a function here that has the signature > 'def append_to_pythonpath(dirs)' > Clients would invoke it with constants defined in this file: > fix_pythonpath.append_to_pythonpath(fix_pythonpath.CHECKOUT_ROOT, > fix_pythonpath.SKIA_SITE_CONFIG_DIR) > > or maybe CHECKOUT_ROOT is always added to the pythonpath like you currently > have, and the append_to_pythonpath function will be used only for additional > dirs that callers care about. I think the last idea sounds best to me: automatically add the checkout root, provide easy mechanisms for adding others.
Last comment https://codereview.chromium.org/330423004/diff/80001/tools/fix_pythonpath.py File tools/fix_pythonpath.py (right): https://codereview.chromium.org/330423004/diff/80001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:20: sys.path.insert(0, path) Why not always add to the end of the sys.path? That way CHECKOUT_ROOT will be before any other dirs added by the caller and it is unlikely that we would want it before the normal pythonpath contents (I think).
https://codereview.chromium.org/330423004/diff/80001/tools/fix_pythonpath.py File tools/fix_pythonpath.py (right): https://codereview.chromium.org/330423004/diff/80001/tools/fix_pythonpath.py#... tools/fix_pythonpath.py:20: sys.path.insert(0, path) On 2014/06/25 15:00:43, rmistry wrote: > Why not always add to the end of the sys.path? That way CHECKOUT_ROOT will be > before any other dirs added by the caller and it is unlikely that we would want > it before the normal pythonpath contents (I think). Done.
LGTM
The CQ bit was checked by borenet@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/330423004/100001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 330423004-100001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Pylint (5 files) (1.52s) failed ************* Module /b/infra_internal/commit_queue/workdir/skia/tools/add_codereview_message.py W0311: 35,0: Bad indentation. Found 4 spaces, expected 2 W0311: 44,0: Bad indentation. Found 4 spaces, expected 2 W0311: 46,0: Bad indentation. Found 4 spaces, expected 2 W0311: 50,0: Bad indentation. Found 4 spaces, expected 2 W0311: 55,0: Bad indentation. Found 4 spaces, expected 2 W0311: 56,0: Bad indentation. Found 4 spaces, expected 2 W0311: 58,0: Bad indentation. Found 4 spaces, expected 2 W0311: 59,0: Bad indentation. Found 8 spaces, expected 4 W0311: 60,0: Bad indentation. Found 4 spaces, expected 2 W0311: 61,0: Bad indentation. Found 8 spaces, expected 4 W0311: 63,0: Bad indentation. Found 4 spaces, expected 2 W0311: 64,0: Bad indentation. Found 4 spaces, expected 2 W0311: 68,0: Bad indentation. Found 4 spaces, expected 2 ************* Module /b/infra_internal/commit_queue/workdir/skia/tools/misc_utils.py W0311: 14,0: Bad indentation. Found 4 spaces, expected 2 W0311: 16,0: Bad indentation. Found 4 spaces, expected 2 W0311: 17,0: Bad indentation. Found 4 spaces, expected 2 W0311: 18,0: Bad indentation. Found 8 spaces, expected 4 W0311: 38,0: Bad indentation. Found 8 spaces, expected 4 W0311: 39,0: Bad indentation. Found 8 spaces, expected 4 W0311: 40,0: Bad indentation. Found 12 spaces, expected 6 W0311: 41,0: Bad indentation. Found 12 spaces, expected 6 W0311: 42,0: Bad indentation. Found 16 spaces, expected 8 W0311: 43,0: Bad indentation. Found 8 spaces, expected 4 W0311: 45,0: Bad indentation. Found 4 spaces, expected 2 W0311: 46,0: Bad indentation. Found 4 spaces, expected 2 W0311: 47,0: Bad indentation. Found 8 spaces, expected 4 W0311: 57,0: Bad indentation. Found 8 spaces, expected 4 W0311: 58,0: Bad indentation. Found 8 spaces, expected 4 ************* Module /b/infra_internal/commit_queue/workdir/skia/tools/roll_deps.py W0311: 69,0: Bad indentation. Found 4 spaces, expected 2 W0311: 80,0: Bad indentation. Found 4 spaces, expected 2 W0311: 81,0: Bad indentation. Found 8 spaces, expected 4 W0311: 82,0: Bad indentation. Found 12 spaces, expected 6 W0311: 84,0: Bad indentation. Found 8 spaces, expected 4 W0311: 85,0: Bad indentation. Found 8 spaces, expected 4 W0311: 86,0: Bad indentation. Found 8 spaces, expected 4 W0311: 87,0: Bad indentation. Found 8 spaces, expected 4 W0311: 89,0: Bad indentation. Found 8 spaces, expected 4 W0311: 90,0: Bad indentation. Found 8 spaces, expected 4 W0311: 91,0: Bad indentation. Found 8 spaces, expected 4 W0311: 97,0: Bad indentation. Found 8 spaces, expected 4 W0311:101,0: Bad indentation. Found 4 spaces, expected 2 W0311:102,0: Bad indentation. Found 4 spaces, expected 2 W0311:104,0: Bad indentation. Found 8 spaces, expected 4 W0311:111,0: Bad indentation. Found 8 spaces, expected 4 W0311:114,0: Bad indentation. Found 8 spaces, expected 4 W0311:119,0: Bad indentation. Found 8 spaces, expected 4 W0311:123,0: Bad indentation. Found 8 spaces, expected 4 W0311:126,0: Bad indentation. Found 8 spaces, expected 4 W0311:129,0: Bad indentation. Found 8 spaces, expected 4 W0311:134,0: Bad indentation. Found 8 spaces, expected 4 W0311:138,0: Bad indentation. Found 8 spaces, expected 4 W0311:139,0: Bad indentation. Found 8 spaces, expected 4 W0311:142,0: Bad indentation. Found 8 spaces, expected 4 W0311:146,0: Bad indentation. Found 4 spaces, expected 2 W0311:147,0: Bad indentation. Found 4 spaces, expected 2 W0311:151,0: Bad indentation. Found 4 spaces, expected 2 W0311:159,0: Bad indentation. Found 4 spaces, expected 2 W0311:161,0: Bad indentation. Found 4 spaces, expected 2 W0311:162,0: Bad indentation. Found 8 spaces, expected 4 W0311:163,0: Bad indentation. Found 8 spaces, expected 4 W0311:165,0: Bad indentation. Found 8 spaces, expected 4 W0311:166,0: Bad indentation. Found 12 spaces, expected 6 W0311:167,0: Bad indentation. Found 16 spaces, expected 8 W0311:168,0: Bad indentation. Found 16 spaces, expected 8 W0311:169,0: Bad indentation. Found 4 spaces, expected 2 W0311:170,0: Bad indentation. Found 8 spaces, expected 4 W0311:171,0: Bad indentation. Found 4 spaces, expected 2 W0311:175,0: Bad indentation. Found 4 spaces, expected 2 W0311:181,0: Bad indentation. Found 4 spaces, expected 2 W0311:183,0: Bad indentation. Found 4 spaces, expected 2 W0311:185,0: Bad indentation. Found 4 spaces, expected 2 W0311:186,0: Bad indentation. Found 8 spaces, expected 4 W0311:187,0: Bad indentation. Found 8 spaces, expected 4 W0311:188,0: Bad indentation. Found 8 spaces, expected 4 W0311:189,0: Bad indentation. Found 8 spaces, expected 4 W0311:190,0: Bad indentation. Found 4 spaces, expected 2 W0311:191,0: Bad indentation. Found 8 spaces, expected 4 W0311:195,0: Bad indentation. Found 4 spaces, expected 2 W0311:211,0: Bad indentation. Found 4 spaces, expected 2 W0311:212,0: Bad indentation. Found 8 spaces, expected 4 W0311:213,0: Bad indentation. Found 8 spaces, expected 4 W0311:215,0: Bad indentation. Found 8 spaces, expected 4 W0311:216,0: Bad indentation. Found 8 spaces, expected 4 W0311:217,0: Bad indentation. Found 8 spaces, expected 4 W0311:218,0: Bad indentation. Found 10 spaces, expected 6 W0311:219,0: Bad indentation. Found 8 spaces, expected 4 W0311:221,0: Bad indentation. Found 8 spaces, expected 4 W0311:224,0: Bad indentation. Found 8 spaces, expected 4 W0311:225,0: Bad indentation. Found 8 spaces, expected 4 W0311:229,0: Bad indentation. Found 8 spaces, expected 4 W0311:233,0: Bad indentation. Found 12 spaces, expected 6 W0311:234,0: Bad indentation. Found 12 spaces, expected 6 W0311:235,0: Bad indentation. Found 16 spaces, expected 8 W0311:237,0: Bad indentation. Found 12 spaces, expected 6 W0311:238,0: Bad indentation. Found 12 spaces, expected 6 W0311:239,0: Bad indentation. Found 16 spaces, expected 8 W0311:240,0: Bad indentation. Found 12 spaces, expected 6 W0311:241,0: Bad indentation. Found 12 spaces, expected 6 W0311:242,0: Bad indentation. Found 16 spaces, expected 8 W0311:244,0: Bad indentation. Found 8 spaces, expected 4 W0311:245,0: Bad indentation. Found 8 spaces, expected 4 W0311:256,0: Bad indentation. Found 8 spaces, expected 4 W0311:260,0: Bad indentation. Found 12 spaces, expected 6 W0311:261,0: Bad indentation. Found 12 spaces, expected 6 W0311:262,0: Bad indentation. Found 12 spaces, expected 6 W0311:263,0: Bad indentation. Found 16 spaces, expected 8 W0311:264,0: Bad indentation. Found 12 spaces, expected 6 W0311:265,0: Bad indentation. Found 12 spaces, expected 6 W0311:266,0: Bad indentation. Found 16 spaces, expected 8 W0311:268,0: Bad indentation. Found 8 spaces, expected 4 W0311:272,0: Bad indentation. Found 4 spaces, expected 2 W0311:277,0: Bad indentation. Found 4 spaces, expected 2 W0311:278,0: Bad indentation. Found 4 spaces, expected 2 W0311:280,0: Bad indentation. Found 4 spaces, expected 2 W0311:281,0: Bad indentation. Found 8 spaces, expected 4 W0311:282,0: Bad indentation. Found 4 spaces, expected 2 W0311:283,0: Bad indentation. Found 8 spaces, expected 4 W0311:284,0: Bad indentation. Found 4 spaces, expected 2 W0311:285,0: Bad indentation. Found 8 spaces, expected 4 W0311:287,0: Bad indentation. Found 4 spaces, expected 2 W0311:288,0: Bad indentation. Found 4 spaces, expected 2 W0311:289,0: Bad indentation. Found 4 spaces, expected 2 W0311:291,0: Bad indentation. Found 4 spaces, expected 2 W0311:292,0: Bad indentation. Found 8 spaces, expected 4 W0311:293,0: Bad indentation. Found 8 spaces, expected 4 W0311:294,0: Bad indentation. Found 4 spaces, expected 2 W0311:295,0: Bad indentation. Found 8 spaces, expected 4 W0311:299,0: Bad indentation. Found 4 spaces, expected 2 Presubmit checks took 3.7s to calculate.
On 2014/06/25 15:11:15, I haz the power (commit-bot) wrote: > Presubmit check for 330423004-100001 failed and returned exit status 1. > > Running presubmit commit checks ... > > ** Presubmit ERRORS ** > Pylint (5 files) (1.52s) failed > ************* Module > /b/infra_internal/commit_queue/workdir/skia/tools/add_codereview_message.py > W0311: 35,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 44,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 46,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 50,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 55,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 56,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 58,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 59,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 60,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 61,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 63,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 64,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 68,0: Bad indentation. Found 4 spaces, expected 2 > ************* Module > /b/infra_internal/commit_queue/workdir/skia/tools/misc_utils.py > W0311: 14,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 16,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 17,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 18,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 38,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 39,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 40,0: Bad indentation. Found 12 spaces, expected 6 > W0311: 41,0: Bad indentation. Found 12 spaces, expected 6 > W0311: 42,0: Bad indentation. Found 16 spaces, expected 8 > W0311: 43,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 45,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 46,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 47,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 57,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 58,0: Bad indentation. Found 8 spaces, expected 4 > ************* Module > /b/infra_internal/commit_queue/workdir/skia/tools/roll_deps.py > W0311: 69,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 80,0: Bad indentation. Found 4 spaces, expected 2 > W0311: 81,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 82,0: Bad indentation. Found 12 spaces, expected 6 > W0311: 84,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 85,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 86,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 87,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 89,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 90,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 91,0: Bad indentation. Found 8 spaces, expected 4 > W0311: 97,0: Bad indentation. Found 8 spaces, expected 4 > W0311:101,0: Bad indentation. Found 4 spaces, expected 2 > W0311:102,0: Bad indentation. Found 4 spaces, expected 2 > W0311:104,0: Bad indentation. Found 8 spaces, expected 4 > W0311:111,0: Bad indentation. Found 8 spaces, expected 4 > W0311:114,0: Bad indentation. Found 8 spaces, expected 4 > W0311:119,0: Bad indentation. Found 8 spaces, expected 4 > W0311:123,0: Bad indentation. Found 8 spaces, expected 4 > W0311:126,0: Bad indentation. Found 8 spaces, expected 4 > W0311:129,0: Bad indentation. Found 8 spaces, expected 4 > W0311:134,0: Bad indentation. Found 8 spaces, expected 4 > W0311:138,0: Bad indentation. Found 8 spaces, expected 4 > W0311:139,0: Bad indentation. Found 8 spaces, expected 4 > W0311:142,0: Bad indentation. Found 8 spaces, expected 4 > W0311:146,0: Bad indentation. Found 4 spaces, expected 2 > W0311:147,0: Bad indentation. Found 4 spaces, expected 2 > W0311:151,0: Bad indentation. Found 4 spaces, expected 2 > W0311:159,0: Bad indentation. Found 4 spaces, expected 2 > W0311:161,0: Bad indentation. Found 4 spaces, expected 2 > W0311:162,0: Bad indentation. Found 8 spaces, expected 4 > W0311:163,0: Bad indentation. Found 8 spaces, expected 4 > W0311:165,0: Bad indentation. Found 8 spaces, expected 4 > W0311:166,0: Bad indentation. Found 12 spaces, expected 6 > W0311:167,0: Bad indentation. Found 16 spaces, expected 8 > W0311:168,0: Bad indentation. Found 16 spaces, expected 8 > W0311:169,0: Bad indentation. Found 4 spaces, expected 2 > W0311:170,0: Bad indentation. Found 8 spaces, expected 4 > W0311:171,0: Bad indentation. Found 4 spaces, expected 2 > W0311:175,0: Bad indentation. Found 4 spaces, expected 2 > W0311:181,0: Bad indentation. Found 4 spaces, expected 2 > W0311:183,0: Bad indentation. Found 4 spaces, expected 2 > W0311:185,0: Bad indentation. Found 4 spaces, expected 2 > W0311:186,0: Bad indentation. Found 8 spaces, expected 4 > W0311:187,0: Bad indentation. Found 8 spaces, expected 4 > W0311:188,0: Bad indentation. Found 8 spaces, expected 4 > W0311:189,0: Bad indentation. Found 8 spaces, expected 4 > W0311:190,0: Bad indentation. Found 4 spaces, expected 2 > W0311:191,0: Bad indentation. Found 8 spaces, expected 4 > W0311:195,0: Bad indentation. Found 4 spaces, expected 2 > W0311:211,0: Bad indentation. Found 4 spaces, expected 2 > W0311:212,0: Bad indentation. Found 8 spaces, expected 4 > W0311:213,0: Bad indentation. Found 8 spaces, expected 4 > W0311:215,0: Bad indentation. Found 8 spaces, expected 4 > W0311:216,0: Bad indentation. Found 8 spaces, expected 4 > W0311:217,0: Bad indentation. Found 8 spaces, expected 4 > W0311:218,0: Bad indentation. Found 10 spaces, expected 6 > W0311:219,0: Bad indentation. Found 8 spaces, expected 4 > W0311:221,0: Bad indentation. Found 8 spaces, expected 4 > W0311:224,0: Bad indentation. Found 8 spaces, expected 4 > W0311:225,0: Bad indentation. Found 8 spaces, expected 4 > W0311:229,0: Bad indentation. Found 8 spaces, expected 4 > W0311:233,0: Bad indentation. Found 12 spaces, expected 6 > W0311:234,0: Bad indentation. Found 12 spaces, expected 6 > W0311:235,0: Bad indentation. Found 16 spaces, expected 8 > W0311:237,0: Bad indentation. Found 12 spaces, expected 6 > W0311:238,0: Bad indentation. Found 12 spaces, expected 6 > W0311:239,0: Bad indentation. Found 16 spaces, expected 8 > W0311:240,0: Bad indentation. Found 12 spaces, expected 6 > W0311:241,0: Bad indentation. Found 12 spaces, expected 6 > W0311:242,0: Bad indentation. Found 16 spaces, expected 8 > W0311:244,0: Bad indentation. Found 8 spaces, expected 4 > W0311:245,0: Bad indentation. Found 8 spaces, expected 4 > W0311:256,0: Bad indentation. Found 8 spaces, expected 4 > W0311:260,0: Bad indentation. Found 12 spaces, expected 6 > W0311:261,0: Bad indentation. Found 12 spaces, expected 6 > W0311:262,0: Bad indentation. Found 12 spaces, expected 6 > W0311:263,0: Bad indentation. Found 16 spaces, expected 8 > W0311:264,0: Bad indentation. Found 12 spaces, expected 6 > W0311:265,0: Bad indentation. Found 12 spaces, expected 6 > W0311:266,0: Bad indentation. Found 16 spaces, expected 8 > W0311:268,0: Bad indentation. Found 8 spaces, expected 4 > W0311:272,0: Bad indentation. Found 4 spaces, expected 2 > W0311:277,0: Bad indentation. Found 4 spaces, expected 2 > W0311:278,0: Bad indentation. Found 4 spaces, expected 2 > W0311:280,0: Bad indentation. Found 4 spaces, expected 2 > W0311:281,0: Bad indentation. Found 8 spaces, expected 4 > W0311:282,0: Bad indentation. Found 4 spaces, expected 2 > W0311:283,0: Bad indentation. Found 8 spaces, expected 4 > W0311:284,0: Bad indentation. Found 4 spaces, expected 2 > W0311:285,0: Bad indentation. Found 8 spaces, expected 4 > W0311:287,0: Bad indentation. Found 4 spaces, expected 2 > W0311:288,0: Bad indentation. Found 4 spaces, expected 2 > W0311:289,0: Bad indentation. Found 4 spaces, expected 2 > W0311:291,0: Bad indentation. Found 4 spaces, expected 2 > W0311:292,0: Bad indentation. Found 8 spaces, expected 4 > W0311:293,0: Bad indentation. Found 8 spaces, expected 4 > W0311:294,0: Bad indentation. Found 4 spaces, expected 2 > W0311:295,0: Bad indentation. Found 8 spaces, expected 4 > W0311:299,0: Bad indentation. Found 4 spaces, expected 2 > > > Presubmit checks took 3.7s to calculate. Ah, right. Many of the scripts here use 4-space indents. I'll submit manually and then fix the whitespace in a different CL.
Message was sent while issue was closed.
Committed patchset #6 manually as rbb0ef0a. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
