tools/fix_pythonpath.py - Issue 330423004: Use new common tools in Python scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/fix_pythonpath.py

Issue 330423004: Use new common tools in Python scripts (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Pylint Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/usr/bin/env python
	borenet 2014/06/23 20:06:30 For convenience. For convenience.
	2 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6

	7 """Adjust the PYTHONPATH appropriately."""
	rmistry 2014/06/24 18:31:05 What you are doing here is including the root chec What you are doing here is including the root checkout directory in the pythonpath to hopefully make it convenience for modules to import other modules. Can you specify something like that here, the current pydoc is not very clear. borenet 2014/06/24 19:17:31 Adjusted the wording but did not specify that the Show quoted text On 2014/06/24 18:31:05, rmistry wrote: > What you are doing here is including the root checkout directory in the > pythonpath to hopefully make it convenience for modules to import other modules. > Can you specify something like that here, the current pydoc is not very clear. Adjusted the wording but did not specify that the root dir is what's added, since we may add more.
	8

	9

	10 import os

	11 import sys

	12

	13

	14 CHECKOUT_ROOT = os.path.realpath(os.path.join(

	15 os.path.dirname(os.path.abspath(__file__)), os.pardir))

	16 sys.path.insert(0, CHECKOUT_ROOT)

	17

	18

	19 if __name__ == '__main__':

	20 print 'PYTHONPATH=%s' % ':'.join(sys.path)
	rmistry 2014/06/24 18:31:05 I am not clear about how this module will be used. I am not clear about how this module will be used. Will it be imported by files and get the checkout root added automatically or will something rely on the above printed line to do anything. borenet 2014/06/24 19:17:31 I expect that scripts will import it. I added the Show quoted text On 2014/06/24 18:31:05, rmistry wrote: > I am not clear about how this module will be used. Will it be imported by files > and get the checkout root added automatically or will something rely on the > above printed line to do anything. I expect that scripts will import it. I added the print just so that if you ran the file directly it would show what its result would have been.
OLD	NEW

« tools/add_codereview_message.py ('K') | « tools/add_codereview_message.py ('k') | tools/git-sync-deps » ('j') | tools/git-sync-deps » ('J')