tools/fix_pythonpath.py - Issue 330423004: Use new common tools in Python scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/fix_pythonpath.py

Issue 330423004: Use new common tools in Python scripts (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix_pythonpath Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6

	7 """Add the checkout root to sys.path, provide mechanisms for adding others."""

	8

	9

	10 import os

	11 import sys

	12

	13

	14 CHECKOUT_ROOT = os.path.realpath(os.path.join(

	15 os.path.dirname(os.path.abspath(__file__)), os.pardir))

	16

	17

	18 def add_to_pythonpath(path):

	19 """Add the given directory to PYTHONPATH."""

	20 sys.path.insert(0, path)
	rmistry 2014/06/25 15:00:43 Why not always add to the end of the sys.path? Tha Why not always add to the end of the sys.path? That way CHECKOUT_ROOT will be before any other dirs added by the caller and it is unlikely that we would want it before the normal pythonpath contents (I think). borenet 2014/06/25 15:02:36 Done. Show quoted text On 2014/06/25 15:00:43, rmistry wrote: > Why not always add to the end of the sys.path? That way CHECKOUT_ROOT will be > before any other dirs added by the caller and it is unlikely that we would want > it before the normal pythonpath contents (I think). Done.
	21

	22

	23 add_to_pythonpath(CHECKOUT_ROOT)

	24

OLD	NEW

« no previous file with comments | « tools/add_codereview_message.py ('k') | tools/git-sync-deps » ('j') | no next file with comments »