Remove vestigial cookie/web app permissions prompting UI now that the async U...

Remove vestigial cookie/web app permissions prompting UI now that the async UI has been approved for M7.This allows me to more easily change the way the appmodal dialog system works.

http://crbug.com/55121
TEST=existing tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59838

[jochen (gone - plz use gerrit), 2010-09-14 15:00:20]

please also delete chrome/app/nibs/CookiePrompt

http://codereview.chromium.org/3299020/diff/15006/4006
File chrome/browser/cocoa/content_exceptions_window_controller.mm (right):

http://codereview.chromium.org/3299020/diff/15006/4006#newcode140
chrome/browser/cocoa/content_exceptions_window_controller.mm:140: const
ContentSetting kSessionAskSettings[] = { CONTENT_SETTING_ALLOW,
please remove this

http://codereview.chromium.org/3299020/diff/15006/4006#newcode518
chrome/browser/cocoa/content_exceptions_window_controller.mm:518: return
l10n_util::GetNSStringWithFixup(IDS_EXCEPTIONS_ASK_BUTTON);
remove these lines

http://codereview.chromium.org/3299020/diff/15006/4009
File chrome/browser/cocoa/content_settings_dialog_controller.mm (right):

http://codereview.chromium.org/3299020/diff/15006/4009#newcode182
chrome/browser/cocoa/content_settings_dialog_controller.mm:182: [tabView_
removeTabViewItem:[tabView_ tabViewItemAtIndex:0]];
please remove the tab view permanently from the XIB file instead of deleting it
programmatically.

http://codereview.chromium.org/3299020/diff/15006/4009#newcode260
chrome/browser/cocoa/content_settings_dialog_controller.mm:260: // position of
the "ask" radio in the old dialog.
please remove this comment.

http://codereview.chromium.org/3299020/diff/15006/4033
File chrome/browser/in_process_webkit/dom_storage_permission_request.cc (right):

http://codereview.chromium.org/3299020/diff/15006/4033#newcode30
chrome/browser/in_process_webkit/dom_storage_permission_request.cc:30: void
DOMStoragePermissionRequest::PromptUser(
remove this method

http://codereview.chromium.org/3299020/diff/15006/4034
File chrome/browser/in_process_webkit/dom_storage_permission_request.h (right):

http://codereview.chromium.org/3299020/diff/15006/4034#newcode19
chrome/browser/in_process_webkit/dom_storage_permission_request.h:19: class
DOMStoragePermissionRequest {
delete this class

http://codereview.chromium.org/3299020/diff/15006/4040
File chrome/browser/renderer_host/database_permission_request.h (right):

http://codereview.chromium.org/3299020/diff/15006/4040#newcode19
chrome/browser/renderer_host/database_permission_request.h:19: class
DatabasePermissionRequest
delete this class

[Ben Goodger (Google), 2010-09-14 17:34:33]

http://codereview.chromium.org/3299020/diff/15006/4009
File chrome/browser/cocoa/content_settings_dialog_controller.mm (right):

http://codereview.chromium.org/3299020/diff/15006/4009#newcode182
chrome/browser/cocoa/content_settings_dialog_controller.mm:182: [tabView_
removeTabViewItem:[tabView_ tabViewItemAtIndex:0]];
On 2010/09/14 15:00:21, jochen wrote:
> please remove the tab view permanently from the XIB file instead of deleting
it
> programmatically.

My read of the .xib is that this radio button is actually shared by all the
content settings panels... and just given a blocking-specific name by the
Cookies panel. I will add a comment here indicating we don't use this radio
button on this tab. It's used by the "load only sandboxed plugins" item on the
plugins tab as well.

[jochen (gone - plz use gerrit), 2010-09-15 13:37:54]

lgtm modulo trybot happiness

thanks for cleaning up this mess

http://codereview.chromium.org/3299020/diff/102001/103006
File chrome/browser/cocoa/content_exceptions_window_controller.mm (right):

http://codereview.chromium.org/3299020/diff/102001/103006#newcode501
chrome/browser/cocoa/content_exceptions_window_controller.mm:501: return
arraysize(kNoSessionSettings);
nit. return showSession_ ? ... : ...;

http://codereview.chromium.org/3299020/diff/102001/103020
File chrome/browser/content_setting_combo_model.cc (right):

http://codereview.chromium.org/3299020/diff/102001/103020#newcode36
chrome/browser/content_setting_combo_model.cc:36: return
arraysize(kNoSessionSettings);
nit. return show_session_ ? ... : ...;

[willchan no longer on Chromium, 2011-03-23 15:44:53]

Ran into this while doing some refactoring of CookiePolicy. It seems like the
removal was incomplete. Is the code being kept around for a future use? Or can
it all be cleaned up?

http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
File chrome/browser/net/chrome_cookie_policy.cc (right):

http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
chrome/browser/net/chrome_cookie_policy.cc:82: 
Is the following code ever supposed to be hit? Or is it dead? Since cookie
prompting got removed, it seems like all these callbacks would be leaked, since
nothing would invoke them. So I hope this code is dead.

http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
chrome/browser/net/chrome_cookie_policy.cc:104: return net::ERR_IO_PENDING;  //
Need to prompt.
What's supposed to happen in this case? Is this case ever hit?

[jochen (gone - plz use gerrit), 2011-03-23 20:36:25]

On 2011/03/23 15:44:53, willchan wrote:
> Ran into this while doing some refactoring of CookiePolicy. It seems like the
> removal was incomplete. Is the code being kept around for a future use? Or can
> it all be cleaned up?
> 
>
http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
> File chrome/browser/net/chrome_cookie_policy.cc (right):
> 
>
http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
> chrome/browser/net/chrome_cookie_policy.cc:82: 
> Is the following code ever supposed to be hit? Or is it dead? Since cookie
> prompting got removed, it seems like all these callbacks would be leaked,
since
> nothing would invoke them. So I hope this code is dead.
> 
>
http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
> chrome/browser/net/chrome_cookie_policy.cc:104: return net::ERR_IO_PENDING; 
//
> Need to prompt.
> What's supposed to happen in this case? Is this case ever hit?

this code path is required for chrome frame where a cookie prompt still exists

[willchan no longer on Chromium, 2011-03-23 22:33:24]

http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
File chrome/browser/net/chrome_cookie_policy.cc (right):

http://codereview.chromium.org/3299020/diff/76003/chrome/browser/net/chrome_c...
chrome/browser/net/chrome_cookie_policy.cc:88:
completions.push_back(Completion::ForSetCookie(callback));
If that's the case, then when do these completions get evicted from the map?