Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4188)

Unified Diff: chrome/browser/cocoa/content_exceptions_window_controller.mm

Issue 3299020: Remove vestigial cookie/web app permissions prompting UI now that the async U... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/content_exceptions_window_controller.mm
===================================================================
--- chrome/browser/cocoa/content_exceptions_window_controller.mm (revision 59533)
+++ chrome/browser/cocoa/content_exceptions_window_controller.mm (working copy)
@@ -135,13 +135,6 @@
CONTENT_SETTING_SESSION_ONLY,
CONTENT_SETTING_BLOCK };
-// The settings shown in the combobox if show_session_ is true, and we still
-// offer the cookie prompt mode.
-const ContentSetting kSessionAskSettings[] = { CONTENT_SETTING_ALLOW,
- CONTENT_SETTING_ASK,
- CONTENT_SETTING_SESSION_ONLY,
- CONTENT_SETTING_BLOCK };
-
} // namespace
////////////////////////////////////////////////////////////////////////////////
@@ -178,8 +171,6 @@
model_.reset(new ContentExceptionsTableModel(
settingsMap_, otrSettingsMap_, settingsType_));
showSession_ = settingsType_ == CONTENT_SETTINGS_TYPE_COOKIES;
- disableCookiePrompt_ = !CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableCookiePrompt);
otrAllowed_ = otrSettingsMap != NULL;
tableObserver_.reset(new UpdatingContentSettingsObserver(self));
updatesEnabled_ = YES;
@@ -505,12 +496,8 @@
}
- (size_t)menuItemCount {
- if (showSession_) {
- return disableCookiePrompt_ ?
- arraysize(kSessionSettings) : arraysize(kSessionAskSettings);
- } else {
- return arraysize(kNoSessionSettings);
- }
+ return showSession_ ? arraysize(kSessionSettings)
+ : arraysize(kNoSessionSettings);
}
- (NSString*)titleForIndex:(size_t)index {
@@ -519,8 +506,6 @@
return l10n_util::GetNSStringWithFixup(IDS_EXCEPTIONS_ALLOW_BUTTON);
case CONTENT_SETTING_BLOCK:
return l10n_util::GetNSStringWithFixup(IDS_EXCEPTIONS_BLOCK_BUTTON);
- case CONTENT_SETTING_ASK:
- return l10n_util::GetNSStringWithFixup(IDS_EXCEPTIONS_ASK_BUTTON);
case CONTENT_SETTING_SESSION_ONLY:
return l10n_util::GetNSStringWithFixup(
IDS_EXCEPTIONS_SESSION_ONLY_BUTTON);
@@ -531,12 +516,7 @@
}
- (ContentSetting)settingForIndex:(size_t)index {
- if (showSession_) {
- return disableCookiePrompt_ ?
- kSessionSettings[index] : kSessionAskSettings[index];
- } else {
- return kNoSessionSettings[index];
- }
+ return showSession_ ? kSessionSettings[index] : kNoSessionSettings[index];
}
- (size_t)indexForSetting:(ContentSetting)setting {

Powered by Google App Engine
This is Rietveld 408576698