chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm - Issue 3299020: Remove vestigial cookie/web app permissions prompting UI now that the async U...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm

Issue 3299020: Remove vestigial cookie/web app permissions prompting UI now that the async U... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/cocoa/content_settings_dialog_controller.mm ('k') | chrome/browser/cocoa/cookie_details.h » ('j') | chrome/browser/net/chrome_cookie_policy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm

===================================================================

--- chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm (revision 59533)

+++ chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm (working copy)

@@ -58,9 +58,7 @@

settingsMap_->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_COOKIES,

CONTENT_SETTING_BLOCK);

- // Since the cookie prompt is disabled per default, the index of the block

- // radio is actually 1 == kCookieAskIndex.

- EXPECT_EQ([controller_ cookieSettingIndex], kCookieAskIndex);

+ EXPECT_EQ([controller_ cookieSettingIndex], kCookieDisabledIndex);

// Change dialog property, check setting.

NSInteger setting;

@@ -69,9 +67,7 @@

settingsMap_->GetDefaultContentSetting(CONTENT_SETTINGS_TYPE_COOKIES);

EXPECT_EQ(setting, CONTENT_SETTING_ALLOW);

- // Since the cookie prompt is disabled per default, the index of the block

- // radio is actually 1 == kCookieAskIndex.

- [controller_ setCookieSettingIndex:kCookieAskIndex];

+ [controller_ setCookieSettingIndex:kCookieDisabledIndex];

setting =

settingsMap_->GetDefaultContentSetting(CONTENT_SETTINGS_TYPE_COOKIES);

EXPECT_EQ(setting, CONTENT_SETTING_BLOCK);