Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 329853007: Remove SkBenchmark::postDraw. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove SkBenchmark::postDraw. Only one bench used this feature, and it's for things that'd be done by the destructor anyway. BUG=skia: Committed: https://skia.googlesource.com/skia/+/683e90611c8a536c3c5feedea27bbbefedf746d2

Patch Set 1 #

Patch Set 2 : dm too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -52 lines) Patch
M bench/PathBench.cpp View 6 chunks +0 lines, -27 lines 0 comments Download
M bench/SkBenchmark.h View 2 chunks +0 lines, -6 lines 0 comments Download
M bench/SkBenchmark.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M bench/benchmain.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M dm/DMBenchTask.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein_C
6 years, 6 months ago (2014-06-17 21:30:00 UTC) #1
bsalomon
On 2014/06/17 21:30:00, mtklein_C wrote: Are bench objects destroyed after they're run? I wonder if ...
6 years, 6 months ago (2014-06-18 13:29:49 UTC) #2
mtklein
On 2014/06/18 13:29:49, bsalomon wrote: > On 2014/06/17 21:30:00, mtklein_C wrote: > > Are bench ...
6 years, 6 months ago (2014-06-18 13:34:32 UTC) #3
mtklein
On 2014/06/18 13:34:32, mtklein wrote: > On 2014/06/18 13:29:49, bsalomon wrote: > > On 2014/06/17 ...
6 years, 6 months ago (2014-06-18 13:35:03 UTC) #4
bsalomon
lgtm
6 years, 6 months ago (2014-06-18 13:44:42 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-18 13:52:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/329853007/1
6 years, 6 months ago (2014-06-18 13:53:10 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-18 14:00:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/329853007/20001
6 years, 6 months ago (2014-06-18 14:01:07 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 14:15:54 UTC) #10
Message was sent while issue was closed.
Change committed as 683e90611c8a536c3c5feedea27bbbefedf746d2

Powered by Google App Engine
This is Rietveld 408576698